Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.| Comment | File | Size | Author |
|---|---|---|---|
| #26 | customers-view.patch | 2.57 KB | TR |
| |||
| #23 | orders-order-history-views.patch | 20.9 KB | TR |
| |||
| #21 | order-history-view.patch | 9.54 KB | TR |
| |||
| #15 | order-schema.patch | 8.34 KB | longwave |
Comments
Comment #2
jian he CreditAttribution: jian he commentedabout the "missing schema display.default.display_options.fields.order_id.link_to_order", the Drupal\uc_order\Plugin\views\field\Id is useless. Because the views standard field plugin can link the id to canonical link, so this issue depends on #2623410: Create order fatal error if content_translation module enabled. to create the usable canonical link.
Comment #3
jian he CreditAttribution: jian he commentedfixed missing schema fields.order_id.link_to_order.
using the standard views field instead of order specified id plugin.
and there is other need fix TODO status:
views.view.uc_customers 32 errors
views.view.uc_orders 34 errors
views.view.uc_order_history 31 errors
Comment #4
jian he CreditAttribution: jian he commentedComment #5
jian he CreditAttribution: jian he commentedfix uc_order_history link_to_order issue.
Current status:
views.view.uc_customers 31 errors
views.view.uc_orders 34 errors
views.view.uc_order_history 29 errors
Comment #6
jian he CreditAttribution: jian he commentedfix missing schema for order_id.id and uc_price.
Current status:
views.view.uc_customers 25 errors
views.view.uc_orders 33 errors List
views.view.uc_order_history 29 errors
Comment #7
jian he CreditAttribution: jian he commentedadd missing plugin_id and fix missing uc_order_status schema.
Current status:
views.view.uc_customers 25 errors
views.view.uc_orders 27 errors List
views.view.uc_order_history 29 errors
Comment #8
jian he CreditAttribution: jian he commentedComment #9
jian he CreditAttribution: jian he commentedComment #10
TR CreditAttribution: TR commentedLet's see what the testbot has to say ...
Comment #13
longwaveComment #15
longwaveReroll.
Comment #16
longwave#15 does improve things but there are still problems:
views.view.uc_customers 20 errors
views.view.uc_orders 24 errors
views.view.uc_order_history 26 errors
Comment #17
TR CreditAttribution: TR commentedMaybe commit what we have so far then follow up with more patches, rather than trying to do everything at once?
Comment #18
TR CreditAttribution: TR commentedComment #19
TR CreditAttribution: TR commentedComment #21
TR CreditAttribution: TR commented#15 doesn't apply so I started from scratch.
Here's a patch that takes care of all the problems with views.view.uc_order_history.
Comment #22
TR CreditAttribution: TR commentedThis patch includes #21 and fixes both views.view.uc_order_history and views.view.uc_orders
Comment #23
TR CreditAttribution: TR commentedForgot the patch ...
Comment #25
longwaveCommitted #23. 12 errors left in views.view.uc_customers.
Comment #26
TR CreditAttribution: TR commentedThis patch brings views.view.uc_customers down to 7 errors, all from the order_id field. We shouldn't need a schema for that ... not sure what is going on there.
Comment #28
longwaveCommitted #26 and then made some final tweaks to the order_id field, I think we are done here now.
Comment #29
TR CreditAttribution: TR commentedYeah, I already tried what you did in 4eecec1 and it eliminates the error until you go save and export the View, at which point you get the bad data (precision etc) back. Somewhere Views thinks order_id is a float rather than an int. That indicates to me there's still something wrong somewhere, even if we edit our config so it conforms to the schema.
Comment #31
longwaveReverted 4eecec1. I think this is a bug in Views' own schema config. When aggregation is enabled (ie. "group_type" is a non empty string) this effectively changes the field type, but the schema config does not take this into account.
A possible workaround is to use another field instead of order ID, as it doesn't really matter what we are counting in this aggregate - we just care about the number of rows in the group.