Would it not be better to allow an option to use the Font Awesome CDN?

<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/font-awesome/4.5.0/css/font-awesome.min.css">
CommentFileSizeAuthor
#9 update-library.patch1.98 KBinders
#8 update_cdn_450-2622592-8.patch2.7 KBmstrelan
#7 update_cdn_450-2622592-7.patch1.5 KBmstrelan
#3 update_cdn_450-2622592-10611574.patch754 bytesjaydee1818
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jaydee1818 created an issue. See original summary.

inders’s picture

inders CreditAttribution: inders as a volunteer and at Faichi Solutions Pvt Ltd commented
Status: Active » Closed (fixed)

this functionality was recently added.

  1. Please make sure you are using latest version of fontawesome module
  2. Visit "admin/config/development/performance" & enable "Use CDN version of FontAwesome." checkbox.
jaydee1818’s picture

jaydee1818 CreditAttribution: jaydee1818 commented
Title: Use Font Awesome CDN » Update Font Awesome CDN
Status: Closed (fixed) » Needs review
FileSize
update_cdn_450-2622592-10611574.patch754 bytes

OK thanks but the module is pointing at an out-of-date version of the Fontawesome CDN. I've updated from version 4.2.0 to 4.5.0

Cheers

  • jaydee1818 authored 509613b on 7.x-2.x 
    Issue #2622592 by jaydee1818: Update Font Awesome CDN
inders’s picture

inders CreditAttribution: inders as a volunteer and at Faichi Solutions Pvt Ltd commented

Thank you for the patch ! Applied & pushed.
Close if Ok !

jaydee1818’s picture

jaydee1818 CreditAttribution: jaydee1818 commented
Status: Needs review » Closed (fixed)
mstrelan’s picture

mstrelan CreditAttribution: mstrelan commented
Version: 7.x-2.5 » 8.x-1.x-dev
Status: Closed (fixed) » Patch (to be ported)
FileSize
update_cdn_450-2622592-7.patch1.5 KB

Can we get this forward ported to Drupal 8? There is also an option to use http://maxcdn.bootstrapcdn.com/font-awesome/latest/css/font-awesome.min.css but I'm not sure if it's safe to rely on that. I can't imagine anything breaking.

mstrelan’s picture

mstrelan CreditAttribution: mstrelan commented
FileSize
update_cdn_450-2622592-8.patch2.7 KB

Missed a few spots

inders’s picture

inders CreditAttribution: inders as a volunteer and at Faichi Solutions Pvt Ltd commented
FileSize
update-library.patch1.98 KB

Failed to apply above patch. Created new patch.

  • inders authored 90b66e3 on 8.x-1.x 
    Issue #2622592 by mstrelan, jaydee1818, inders: Update Font Awesome CDN
inders’s picture

inders CreditAttribution: inders as a volunteer and at Faichi Solutions Pvt Ltd commented
Status: Patch (to be ported) » Fixed
inders’s picture

inders CreditAttribution: inders as a volunteer and at Faichi Solutions Pvt Ltd commented
Assigned: Unassigned » inders
Status: Fixed » Closed (fixed)
truls1502’s picture

truls1502
he/him
Primary language Norwegian Bokmål
CreditAttribution: truls1502 as a volunteer and at SignWo AS commented
Assigned: inders » Unassigned

Unassigned the user