Add a "Delete" link for vocabularies on the vocabulary listing page

I think this issue makes sense.

This is on the fine line between a bug, a feature, or a task. I am going with feature, which postpones it to 8.1.x.

a) I could be wrong. ;-)

b) If it is a feature request, by definition it moves to 8.1.x. Actually the same is the case for "string, markup, user interface, or render array changes", which this issue is as well.

Added "Delete vocabulary" link as suggested.

May I know the cause of patch failure? The functionality is working fine at my end.
Does it failed after applying the patch?

Please review new patch

Thanks for review. Please move to rtbc.

I tried applying the patch, but the patch does not apply. PFA screenshot Patch_failed.png.
We need to work on the patch.

@Dinesh18 : Kindly test it with Drupal 8 current Development version.

Hello,

#11 patch is working properly. PFA screenshots for different scenarios.
Also, PFA git bash warning errors which needs to be resolved.

Need to work on patch to remove warnings.

There's no reason to move this to critical suddenly

@Dinesh18 : New patch won't give the warning. Thank you for review it. Please check again new patch.

If there is broad agreement, this may as well be a task.

@alokbhatt : I have tested the new patch #18 and it doesn't give any warnings in git bash and it is working as expected. PFA screenshot
Changing the status to RTBC

It would be great to have UI review from a product manager on this.

The other listings where there is a delete link (content types, views, custom block types, view modes, likely others as well) the label is only "Delete", not "Delete ", so I think we should do that here as well. The position of the link is correct: it should be the last one.

Thanks for working on this!

Patch works as intended for me.

+++ b/core/modules/taxonomy/src/VocabularyListBuilder.php
@@ -36,6 +36,10 @@ public function getDefaultOperations(EntityInterface $entity) {
+    if (isset($operations['delete'])) {
+      $operations['delete']['title'] = t('Delete');
+    }
+

This is not necessary the default title is 'Delete' ... plus t() would be wrong here - and yes it is wrong above.

Also I think we should file a followup issue to review the order of the vocabulary operations and consider changing "Edit vocabulary" to "Edit" to match content types etc... In my opinion the order should be the same as what you see on admin/structure/types for content types (which is the same as you see on admin/structure/block/block-content/types and admin/structure/comment) but with "Add terms" and "List terms" first because these are the most common operations for people - happy to defer that to a UX expert though. What I'm pretty sure about is that the order on admin/structure/taxonomy is pretty odd.

Can we have clear requirement? Because initially there was no such comment on link title and if I am not wrong issue was about "Delete" link was not there and depends on that I made a patch file.

Current situation:

• There is no link to delete a vocabulary in the dropbutton on the vocabulary listing page

Desired situation:

• Add a delete link to the dropbutton.
• The label should be "Delete".
• The link should be the very last one in the dropbutton.

Additional steps

• Create a new issue to improve the overall sorting of items in this dropbutton.
• @alexpott is right in that the ordering should be more consistent with similar dropbuttons. You can copy-paste his last paragraph of #26 there in the issue body.

Does that help?

Yes, that is clear.

@alexpott: Please clear the order, it should like below:
List terms
Add terms
Manage fields
Manage form display
Manage display
Edit
Delete

Please correct the order if not suitable, also publishing new path with the same. Please review new patch.

As you said t() is not required that doesn't make sense to me, because it is labels which should be translatable, correct me if I am wrong.

Adding patch because previous one was failed.

No sure why the patch is not going into the queue for testing, so I am uploading it again.

+++ b/core/modules/taxonomy/src/VocabularyListBuilder.php
@@ -33,9 +33,13 @@ public function getDefaultOperations(EntityInterface $entity) {
+      $operations['edit']['title'] = t('Edit');
...
+    if (isset($operations['delete'])) {
+      $operations['delete']['title'] = t('Delete');
+    }

what Alex is saying is that these lines are not necessary because those are the default labels from the parent method. Just remove them and it will look the same.

@Berdir: Thanks for review. Please review new patch.

A test is looking for an edit vocabulary link, you need to update that to use just Edit

@Berdir: You suggest to remove "Edit" line in #32, anyways I tested in my local machine, it shows "Edit" only.

Please check updated patch.

No, you misunderstood.

The previous patch was fine. But as you can see, it has a failing test that we need to fix. In VocabularyUiTest.php, it is still looking for "Edit vocabulary", that's what you need to update. That and going back to the patch from #40.

@yoroy -I would propose to keep Lable as 'Delete Vocabulary'.
For other cases like content types or menus - Delete , Edit lables are making clear sense.
But Vocaulary will have terms associated with it . Also 'List terms' , 'Add terms' links are also there in the dropdown .
Keeping link label as 'Edit Vocabulary' and 'Delete Vocabulary' would give better experience.

Current situation:
There is no link to delete a vocabulary in the dropbutton on the vocabulary listing page
Desired situation:
Add a delete link to the dropbutton.
The label should be "Delete Vocabulary".
The link should be the very last one in the dropbutton.

*Maybe we can also update 'Add terms' lable to 'Add term'

Cheers,
SwapS

Well, deleting a vocabulary *also* deletes its terms. Which is tricky in itself, but I don't think "Delete vocabulary" instead of "Delete" helps with that. If anything, it might even suggest that the terms inside might not get deleted.

Agreed with #51.

What we are missing is to extend the tests to make sure that there is a Delete operation now as well and clicking it to make sure we end up on the delete form.

How does basic and essential functionality like "delete vocabulary" not exist when 8.x core is already at 8.4?
Why two years, and still this patch hasn't been made part of a release?

Re #54 : The delete link is available when editing a vocabulary. You can delete a vocabulary. This is *just* the link in the dropdown buttons in the vocabulary page list which miss.

Duplicate of #2469545: Vocabulary listing missing delete operation for vocabularies.