Issue related to minor spelling mistakes in Documentation

CommentFileSizeAuthor
#20 examples-misspelling-2621324-20.patch14.27 KByogeshmpawar
#15 examples-misspelling-2621324-15.patch25.51 KBseworthi
#13 examples-misspelling-2621324-13.patch13.07 KBseworthi
#8 interdiff-2621324-6-8.txt721 bytesheykarthikwithu
#8 2621324-8.patch13.13 KBheykarthikwithu
#6 interdiff-2621324-2-6.txt674 bytesheykarthikwithu
#6 2621324-6.patch13.14 KBheykarthikwithu
#2 2621324-2.patch13.07 KBxaiwant

Comments

xaiwant created an issue. See original summary.

xaiwant’s picture

xaiwant commented
Assigned: xaiwant » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 2621324-2.patch13.07 KB

minor spelling mistake taken care.
applied patch

Status: Needs review » Needs work

The last submitted patch, 2: 2621324-2.patch, failed testing.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Status: Needs work » Needs review
Issue tags: +typos

Status: Needs review » Needs work

The last submitted patch, 2: 2621324-2.patch, failed testing.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new 2621324-6.patch13.14 KB
new interdiff-2621324-2-6.txt674 bytes

roll backed the patch with changes.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 6: 2621324-6.patch, failed testing.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Status: Needs work » Needs review
StatusFileSize
new 2621324-8.patch13.13 KB
new interdiff-2621324-6-8.txt721 bytes

Status: Needs review » Needs work

The last submitted patch, 8: 2621324-8.patch, failed testing.

navneet0693’s picture

navneet0693 commented
Status: Needs work » Needs review

I don't think the tests failing are related to this patch. I think we should get it reviewed.

Status: Needs review » Needs work

The last submitted patch, 8: 2621324-8.patch, failed testing.

navneet0693’s picture

navneet0693 commented
Status: Needs work » Reviewed & tested by the community

Errors thrown on this patch aren't one related to this patch, I am passing this patch. Please correct me, if I m wrong !

seworthi’s picture

seworthi commented
StatusFileSize
new examples-misspelling-2621324-13.patch13.07 KB

Fixed error in patch for ajax_examples.module file. Contained a sentence in a sentence.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 13: examples-misspelling-2621324-13.patch, failed testing.

seworthi’s picture

seworthi commented
Component: Other » Action Example
StatusFileSize
new examples-misspelling-2621324-15.patch25.51 KB

Fixed test fail.

seworthi’s picture

seworthi commented
Component: Action Example » Other
seworthi’s picture

seworthi commented
Status: Needs work » Reviewed & tested by the community
navneet0693’s picture

navneet0693 commented
Status: Reviewed & tested by the community » Needs review

Hey seworthi,

Assuming that you are new to issue queues :), when you submit the patch to an issue, let it be reviewed by someone else ! not by the patch submitter itself.

navneet0693’s picture

navneet0693 commented
Status: Needs review » Needs work 
  1. +++ b/examples-misspelling-2621324-14.patch
@@ -0,0 +1,263 @@
+ ¶

    Extra white space issue. 

  2. +++ b/examples-misspelling-2621324-14.patch
@@ -0,0 +1,263 @@
+ ¶

    Spacing issues. 

  3. +++ b/examples-misspelling-2621324-14.patch
@@ -0,0 +1,263 @@
++  // we provide the opportunity for actions to alter the account object, and

    There are a lot of duplicate lines in patch. Seems like a patch has copied to code and recreated patch.

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location Pune(MH), INDIA 🇮🇳
commented
Status: Needs work » Needs review
StatusFileSize
new examples-misspelling-2621324-20.patch14.27 KB
navneet0693’s picture

navneet0693 commented
Status: Needs review » Reviewed & tested by the community

Patch is simple and straight forward.

Torenware’s picture

Torenware commented
Status: Reviewed & tested by the community » Fixed

Looks just fine to me. Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.