Problem/Motivation

Role summaries to show on the Roles page

Proposed resolution

Add the Feature

CommentFileSizeAuthor
#10 interdiff-2619886-2-8.txt1.46 KBaditya_anurag
#8 2619886-8.patch3.59 KBaditya_anurag
#2 2619886-2.patch3.61 KBrakesh.gectcr
ewq.png1 MBaditya_anurag

Comments

aditya_anurag created an issue. See original summary.

rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language English
Location Manchester
commented
Status: Active » Needs review
StatusFileSize
new 2619886-2.patch3.61 KB
krknth’s picture

krknth commented

Thanks, need some time to review.

krknth’s picture

krknth commented

@heykarthikwithu will be reviewing.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Assigned: Unassigned » heykarthikwithu
heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Title: Role summaries to show on the Roles page » Role Help text to show on the Roles page.
Assigned: heykarthikwithu » Unassigned

Patch #2 adds the help text to the roles on the "admin/people/permissions/roles" page.

Minor coding formats needs to be changed in the patch.

+  $theme_registry['user_admin_roles']['function'] = 'role_help_user_admin_roles';
+
 }
+      $row[] = t('@name', array('@name' => $name)) . '<br><div class="description">' . check_plain($summary) . '</div>';
+      $edit = l(t('edit role'), 'admin/people/permissions/roles/edit/' . $rid);
     }
+      $row[] = drupal_render($form['roles'][$rid]['weight']);
+      $row[] = $edit;
+      $row[] = l(t('edit permissions'), 'admin/people/permissions/' . $rid);
+
+    $rows[] = array('data' => $row, 'class' => array('draggable'));
+
   }
heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Status: Needs review » Needs work
aditya_anurag’s picture

aditya_anurag commented
Status: Needs work » Needs review
StatusFileSize
new 2619886-8.patch3.59 KB

@heykarthikwithu
Applied the changes as per #6 comment.

krknth’s picture

krknth commented

@aditya_anurag, it will be easy to review if you add interdiff file :)

aditya_anurag’s picture

aditya_anurag commented
StatusFileSize
new interdiff-2619886-2-8.txt1.46 KB

@krknth,
please find the interdiff file.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Status: Needs review » Reviewed & tested by the community

Patch #8 has changes, can be pushed. So moving to RTBC.

Note: A minor 'new line' needs to be removed while pushing the patch.

-  $theme_registry['user_admin_new_role']['function'] = 'role_help_user_admin_new_role';
+  $theme_registry['user_admin_roles']['function'] = 'role_help_user_admin_roles';
 }
 
+
 /**
  * Theme a role help section.

  • krknth committed 9ece7e0 on authored by aditya_anurag 
    Issue #2619886 by aditya_anurag, rakesh.gectcr, heykarthikwithu, krknth...
krknth’s picture

krknth commented
Status: Reviewed & tested by the community » Fixed

Thanks! committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.