I can provide guidance on what these should be as need be, but we basically just need short, simple summaries of the settings contained in vertical tabs. For example, if the status is active, we wouldn't use a summary of "Status: Active", it would just say "Active".

CommentFileSizeAuthor
#12 2616356-12-add_setting_summaries.patch751 bytesjkuma
#6 2616356-6-add_setting_summaries.patch2.6 KBnvahalik
#5 compatibility2.gif138.96 KBnvahalik
#4 2616356-4-add_setting_summaries.patch2.6 KBnvahalik

Comments

rszrama created an issue. See original summary.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Related issues: +#2599944: Move discount status to a vertical tab

Linking to relevant issue which was committed to unblock work on this #2616356: Add setting summaries to vertical tabs.

nvahalik’s picture

nvahalik commented
Assigned: Unassigned » nvahalik
nvahalik’s picture

nvahalik commented
Status: Active » Needs review
StatusFileSize
new 2616356-4-add_setting_summaries.patch2.6 KB

Extended the existing JS file to add support for vertical queries.

nvahalik’s picture

nvahalik commented
Issue summary: View changes
StatusFileSize
new compatibility2.gif138.96 KB

Also, here is a handy recording of the functionality:

animated gif of the functionality included in the patch

nvahalik’s picture

nvahalik commented
StatusFileSize
new 2616356-6-add_setting_summaries.patch2.6 KB

Update language to change "None except" to "Only with".

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented

I just gave this a run on Simplytest.me, and WOOHOO. That makes the vertical tabs nice and slick! +1

jkuma’s picture

jkuma commented
Status: Needs review » Reviewed & tested by the community

Great patch, thank you nvahalik!

I'm pushing it right away.

  • jkuma committed bdd515e on 7.x-1.x authored by nvahalik 
    Issue #2616356 by nvahalik: Add setting summaries to vertical tabs
jkuma’s picture

jkuma commented
Status: Reviewed & tested by the community » Fixed
rszrama’s picture

rszrama commented
Status: Fixed » Needs work

From the screenshot, we shouldn't be using "Weight" when the field is called "Sort order." I'll review this for consistency and we can fix the patch.

jkuma’s picture

jkuma commented
Status: Needs work » Needs review
StatusFileSize
new 2616356-12-add_setting_summaries.patch751 bytes

The weight label has been replaced by "Sort order".

nvahalik’s picture

nvahalik commented

You beat me to it. I tried to upload the patch as you were committing it.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Assigned: nvahalik » Unassigned
Status: Needs review » Fixed

Thanks you I've committed this follow-up. good catch @rszrama.

  • joelpittet committed 8f414b5 on 7.x-1.x authored by jkuma 
    Issue #2616356 by nvahalik, jkuma, rszrama: Add setting summaries to...
rszrama’s picture

rszrama commented

Ok. fwiw, I don't think "Discount options" makes sense either, as these are really pieces of metadata related to if / when a discount is applied. I'd like to review these labels in general, but I can use a follow-up issue to recommend any changes I suppose.

We'd need to do the same once Usage / Date are merged as well.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

yeah there is definitely language clean-up needed here, agree about that "Discount options" though don't have a better suggestion ATM. I still need to clean-up the options for the compatibility radios, they are overly verbose at the moment.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.