Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I can provide guidance on what these should be as need be, but we basically just need short, simple summaries of the settings contained in vertical tabs. For example, if the status is active, we wouldn't use a summary of "Status: Active", it would just say "Active".
Comment | File | Size | Author |
---|---|---|---|
#12 | 2616356-12-add_setting_summaries.patch | 751 bytes | jkuma |
#6 | 2616356-6-add_setting_summaries.patch | 2.6 KB | nvahalik |
#4 | 2616356-4-add_setting_summaries.patch | 2.6 KB | nvahalik |
Comments
Comment #2
mglamanLinking to relevant issue which was committed to unblock work on this #2616356: Add setting summaries to vertical tabs.
Comment #3
nvahalik CreditAttribution: nvahalik at Centarro commentedComment #4
nvahalik CreditAttribution: nvahalik at Centarro commentedExtended the existing JS file to add support for vertical queries.
Comment #5
nvahalik CreditAttribution: nvahalik at Centarro commentedAlso, here is a handy recording of the functionality:
Comment #6
nvahalik CreditAttribution: nvahalik at Centarro commentedUpdate language to change "None except" to "Only with".
Comment #7
mglamanI just gave this a run on Simplytest.me, and WOOHOO. That makes the vertical tabs nice and slick! +1
Comment #8
jkuma CreditAttribution: jkuma as a volunteer commentedGreat patch, thank you nvahalik!
I'm pushing it right away.
Comment #10
jkuma CreditAttribution: jkuma as a volunteer commentedComment #11
rszrama CreditAttribution: rszrama at Centarro commentedFrom the screenshot, we shouldn't be using "Weight" when the field is called "Sort order." I'll review this for consistency and we can fix the patch.
Comment #12
jkuma CreditAttribution: jkuma as a volunteer commentedThe weight label has been replaced by "Sort order".
Comment #13
nvahalik CreditAttribution: nvahalik at Centarro commentedYou beat me to it. I tried to upload the patch as you were committing it.
Comment #14
joelpittetThanks you I've committed this follow-up. good catch @rszrama.
Comment #16
rszrama CreditAttribution: rszrama at Centarro commentedOk. fwiw, I don't think "Discount options" makes sense either, as these are really pieces of metadata related to if / when a discount is applied. I'd like to review these labels in general, but I can use a follow-up issue to recommend any changes I suppose.
We'd need to do the same once Usage / Date are merged as well.
Comment #17
joelpittetyeah there is definitely language clean-up needed here, agree about that "Discount options" though don't have a better suggestion ATM. I still need to clean-up the options for the compatibility radios, they are overly verbose at the moment.