I install the "localization client" module and it disables simplemenu and maybe other javascript stuff

Uninstalling brings the simplemenu back.

Firebug complains about the following error:

ret[ret.length - 1] has no properties
e("#edit-copy", Document modules)jquery.js (line 2)
e(Document modules)jquery.js (line 2)
e([Document modules], function())jquery.js (line 2)
e("#l10n-client-form #edit-copy")jquery.js (line 2)
e("#l10n-client-form #edit-copy", undefined)jquery.js (line 2)
e("#l10n-client-form #edit-copy", undefined)jquery.js (line 2)
l10nEditorAttach()l10n_client.js (line 82)
e()jquery.js (line 2)
e()jquery.js (line 2)
e([function(), function(), function(), 4 more...], function(), undefined)

I am using the legacy "jquery update" module (jquery 1.1.2)

Comments

michalczernik’s picture

Title:localization client kills simplemenu» localization client kills simplemenu and other javascripts
Version:5.x-1.0» 6.x-1.7
Priority:Normal» Critical

Is this really one year old bug? Still unfixed?

This module is breaking all Javascripts.. Regardless you use 'jQuery update' or not.

:-(

Gábor Hojtsy’s picture

Status:Active» Closed (fixed)

We've recently added code to not re-attach behavior, which should help. It would be great to get actual examples. The 5.x example that the issue was submitted for is indeed ages old. And while a bug standing around for ages might look strange, it also means others did not reproduce it or did not think it was important to fix. If this would be critical, others would be around to confirm.

I've just tried the current version of l10n_client with the current version of simplemenu, and they both work just fine. Please specify if actual modules have interaction issues.

shwx’s picture

Status:Closed (fixed)» Active

I've the same problem...

Gábor Hojtsy’s picture

Status:Active» Postponed (maintainer needs more info)

Have you tried the latest development snapshot? (I intend to do a release soon, so more testing would be awesome :).

shwx’s picture

Yes, I tried the last, but without succes :(

Gábor Hojtsy’s picture

Ok, we need more information from your Javascript error logs then.

EugenMayer’s picture

Status:Postponed (maintainer needs more info)» Active

Also issues with wysiwyg image upload http://drupal.org/node/857546#comment-3217076 (confirmed on several clients ). Seems like JSON or headers are broken by the client.

I suggest headers

Gábor Hojtsy’s picture

You suggest, or you have some proof? The issues above suggest problems with how elements are not found by l10n_client and the latest dev versions use classes to identify elements rather then IDs. Are you using the latest dev version?

EugenMayer’s picture

Gabor no, i have no proof of the suggestion - i had not time for further investigation. The only thing i had proof is that the localisation client is the cause and its breaking other modules too.

AFAIK those people used the stable. You expect the dev to work out here?

Gábor Hojtsy’s picture

Yes, the initial issue above can be solved by (a) not using ID selectors (b) not running the behavior multiple times. We now do both in the dev version. I hoped to get some 3rd party testing before I push a new version, and since you experience the issue, you'd be best to test. I can always release a new stable version, but would not planned to annoy anybody to release without fixing critical issues :)

EugenMayer’s picture

Sounds reasonable. I will report back Gabor, thanks for the work!

EugenMayer’s picture

Status:Active» Reviewed & tested by the community

Gabor its veryfied, working with dev!

Gábor Hojtsy’s picture

Status:Reviewed & tested by the community» Fixed

Nothing to commit here, this was committed already.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

gease’s picture

Version:6.x-1.7» 6.x-2.0
Priority:Critical» Normal
Status:Closed (fixed)» Active

The issue still persists in l10n_client 6.x-2.0 and current dev. It kills wysiwyg_imageupload module.

unegro’s picture

Version:7.x-1.0-beta3» 6.x-2.0

This bug still happening in Drupal 7.2

There is a mismissed configuration?

unegro’s picture

Version:6.x-2.0» 7.x-1.0-beta3

It happens too in Drupal 7.2

Gábor Hojtsy’s picture

Version:6.x-2.0» 7.x-1.0-beta3

Can you try if the improvements from #862590: Cleanup and optimization on l10n_client.js help? Thanks.

unegro’s picture

Priority:Normal» Critical

I tried the suggested patches

The patch l10n_client-global.patch didn't work
The patch l10n_client-complete2.patch din't work
The patch D7-patch-combined.patch didn't work
The patch l10n_client-cache-client.patch didn't work

Firebug Gives me This error:
$.cookie is not a function
switch($.cookie('Drupal_l10n_client')) {

Do you have another suggestion?

Gábor Hojtsy’s picture

@unegro: Yes, that should be a duplicate of #522646: jquery.cookie.js incompatible with Apache mod_security by default, see info there.

SebCorbin’s picture

Status:Active» Postponed (maintainer needs more info)

Is this issue still happening since #862590: Cleanup and optimization on l10n_client.js has been committed?

joel_osc’s picture

Issue summary:View changes

Just an FYI, I experienced this issue when using the TOC module - found a workaround to disable hot-keys on the l10 and the toc started working again. My workaround involved commenting out the following lines:

     // Register keybindings using jQuery hotkeys
        // if ($.hotkeys) {
        //   $.hotkeys.add(Drupal.l10nClient.keys.toggle, function () {
        //     Drupal.l10nClient.key('toggle');
        //   });
        //   $.hotkeys.add(Drupal.l10nClient.keys.clear, {target: '#l10n-client .string-search', type: 'keyup'}, function () {
        //     Drupal.l10nClient.key('clear');
        //   });
        // }
Mark_L6n’s picture

Another FYI, I just found that Colorbox was not working properly on views pages with language prefixes in the path, see here. The code/link being generated was proper, just for some reason the javascript would not kick in and load the lightbox. (Localization client 7.x-1.3, Drupal 7.30).

Mark_L6n’s picture

Additionally, Bootstrap theme users are reporting conflicts: #1887224: Drupal localization client support