We need tests.

CommentFileSizeAuthor
#35 tests_add_them-2615262-35.patch3.8 KBmglaman
#27 tests_add_them-2615262-27.patch4.3 KBjoelpittet
#27 interdiff.txt3.27 MBjoelpittet
#22 base_test_-_html_-____Sites_d7_html_.png154.97 KBjoelpittet
#17 tests_add_them-2615262-17.patch3.8 KBmglaman
#15 tests_add_them-2615262-15.patch3.8 KBmglaman
#13 tests_add_them-2615262-13.patch3.7 KBmglaman
#10 tests_add_them-2615262-10.patch3.04 KBmglaman
#6 tests_add_them-2615262-6.patch2.97 KBmglaman
#2 tests_add_them-2615262-2.patch2.97 KBmglaman

Comments

mglaman created an issue. See original summary.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Active » Needs review
StatusFileSize
new tests_add_them-2615262-2.patch2.97 KB

Round 1.

Status: Needs review » Needs work

The last submitted patch, 2: tests_add_them-2615262-2.patch, failed testing.

The last submitted patch, 2: tests_add_them-2615262-2.patch, failed testing.

The last submitted patch, 2: tests_add_them-2615262-2.patch, failed testing.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs work » Needs review
StatusFileSize
new tests_add_them-2615262-6.patch2.97 KB

That's a new error.

Status: Needs review » Needs work

The last submitted patch, 6: tests_add_them-2615262-6.patch, failed testing.

The last submitted patch, 6: tests_add_them-2615262-6.patch, failed testing.

The last submitted patch, 6: tests_add_them-2615262-6.patch, failed testing.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs work » Needs review
StatusFileSize
new tests_add_them-2615262-10.patch3.04 KB

Again! Dependencies now being enabled?

Status: Needs review » Needs work

The last submitted patch, 10: tests_add_them-2615262-10.patch, failed testing.

The last submitted patch, 10: tests_add_them-2615262-10.patch, failed testing.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs work » Needs review
StatusFileSize
new tests_add_them-2615262-13.patch3.7 KB

This should do it!

Status: Needs review » Needs work

The last submitted patch, 13: tests_add_them-2615262-13.patch, failed testing.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs work » Needs review
StatusFileSize
new tests_add_them-2615262-15.patch3.8 KB

Tests past locally. Now the "why not with testbot" dance.

Status: Needs review » Needs work

The last submitted patch, 15: tests_add_them-2615262-15.patch, failed testing.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs work » Needs review
StatusFileSize
new tests_add_them-2615262-17.patch3.8 KB

For kicks, see if issue is permissions.

Status: Needs review » Needs work

The last submitted patch, 17: tests_add_them-2615262-17.patch, failed testing.

Status: Needs work » Needs review

joelpittet queued 17: tests_add_them-2615262-17.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 17: tests_add_them-2615262-17.patch, failed testing.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

It seems like a dependency loading issue though I'm having similar problems running the tests locally.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
StatusFileSize
new base_test_-_html_-____Sites_d7_html_.png154.97 KB

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

Nevermind #22 that was my bad it's not evident when you don't have a dependency locally. It gives similar errors (false positives)

The tests pass locally, I think tag a new release and it may just magically pick up like it did for commerce_discount.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented

I just tagged a release, which is why I started on the tests. I'll ping infra folks tomorrow maybe.

mglaman queued 17: tests_add_them-2615262-17.patch for re-testing.

The last submitted patch, 17: tests_add_them-2615262-17.patch, failed testing.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
StatusFileSize
new interdiff.txt3.27 MB
new tests_add_them-2615262-27.patch4.3 KB

Let's see if this will help weed out what's not being enabled as we are lacking some info.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 27: tests_add_them-2615262-27.patch, failed testing.

mglaman queued 17: tests_add_them-2615262-17.patch for re-testing.

The last submitted patch, 17: tests_add_them-2615262-17.patch, failed testing.

Status: Needs work » Needs review

mglaman queued 27: tests_add_them-2615262-27.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 27: tests_add_them-2615262-27.patch, failed testing.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs work » Needs review

Try with DrupalCI

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
StatusFileSize
new tests_add_them-2615262-35.patch3.8 KB

crossing fingers

Status: Needs review » Needs work

The last submitted patch, 35: tests_add_them-2615262-35.patch, failed testing.

The last submitted patch, 35: tests_add_them-2615262-35.patch, failed testing.

The last submitted patch, 35: tests_add_them-2615262-35.patch, failed testing.

  • mglaman committed 6034833 on 7.x-1.x 
    Issue #2615262 by mglaman, joelpittet: TESTS: Add them
mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs work » Fixed

I just committed; I think dev just needed to rolled over so DrupalCI stopped borking.

  • mglaman committed 6034833 on 8.x-2.x 
    Issue #2615262 by mglaman, joelpittet: TESTS: Add them

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.