Remove !placeholders from code

This patch needs some work.
I found this change notice that is related https://www.drupal.org/node/2575819.
I do not have the error message, but the text in the page is wrong, it is encoded in html, so we need to fix it.
What we need to change in the patch: "<code><?php ... ?></code>" show as this, but we need <code></code> as html, it will not show on the page, it will only change the way that <?php ... ?> looks.

I just commited https://www.drupal.org/node/2592539#comment-10569470 which fix one of this errors because it is older than this issue, but we still have some work to do here.

I am getting !placeholder errors on admin/config/content/formats/geshifilter from GeshiFilterSettingsForm.php line 330

I see that these placeholder tags were removed from Drupal 7: https://www.drupal.org/node/2575819

This is fixed with this commit, thanks.

Please report if you find this in another place.

@yukare

The .module file is still full of the !placeholders which results in the error "User error: Invalid placeholder in string...".
Could you please quickly change them to @placeholders? find&replace+commit should be quicker than me creating a patch. :)

Regards

I get similar errors on node edit form when using a text format with geshi filter enabled.

User error: Invalid placeholder (!tags) in string: You can enable syntax highlighting of source code with the following tags: !tags. in Drupal\Component\Render\FormattableMarkup::placeholderFormat() (line 240 of core/lib/Drupal/Component/Render/FormattableMarkup.php).
Drupal\Component\Render\FormattableMarkup::placeholderFormat('You can enable syntax highlighting of source code with the following tags: !tags.', Array)
Drupal\Core\StringTranslation\TranslatableMarkup->render()
Drupal\Core\StringTranslation\TranslatableMarkup->__toString()
Drupal\Core\Render\Renderer->doRender(Array, )
Drupal\Core\Render\Renderer->render(Array)
Drupal\Core\Template\TwigExtension->escapeFilter(Object, Array, 'html', NULL, 1)
__TwigTemplate_ad1f1b6c7e986361e8bc195a2e601d9ca7479243bbd4352c457101d970c101b2->doDisplay(Array, Array)
Twig_Template->displayWithErrorHandling(Array, Array)
Twig_Template->display(Array)
Twig_Template->render(Array)
twig_render_template('core/themes/classy/templates/content-edit/filter-tips.html.twig', Array)
Drupal\Core\Theme\ThemeManager->render('filter_tips', Array)
Drupal\Core\Render\Renderer->doRender(Array, )
Drupal\Core\Render\Renderer->render(Array)
Drupal\Core\Template\TwigExtension->escapeFilter(Object, Array, 'html', NULL, 1)
__TwigTemplate_4b57c6eac7bf1c6d58000c0c95154ce221823bf00118ee60b76e4deaf63e542f->doDisplay(Array, Array)
Twig_Template->displayWithErrorHandling(Array, Array)
Twig_Template->display(Array)
Twig_Template->render(Array)
twig_render_template('core/themes/classy/templates/content-edit/filter-guidelines.html.twig', Array)
Drupal\Core\Theme\ThemeManager->render('filter_guidelines', Array)
Drupal\Core\Render\Renderer->doRender(Array)
Drupal\Core\Render\Renderer->doRender(Array)
Drupal\Core\Render\Renderer->doRender(Array)
Drupal\Core\Render\Renderer->doRender(Array, )
Drupal\Core\Render\Renderer->render(Array)
Drupal\Core\Template\TwigExtension->escapeFilter(Object, Array, 'html', NULL, 1)
__TwigTemplate_9b8f92036bb236516341f537e4092bd675a0da9934ff65d2f64921ab29b0fc22->doDisplay(Array, Array)
Twig_Template->displayWithErrorHandling(Array, Array)
Twig_Template->display(Array)
Twig_Template->render(Array)
twig_render_template('core/themes/classy/templates/form/field-multiple-value-form.html.twig', Array)
Drupal\Core\Theme\ThemeManager->render('field_multiple_value_form', Array)
Drupal\Core\Render\Renderer->doRender(Array)
Drupal\Core\Render\Renderer->doRender(Array)
Drupal\Core\Render\Renderer->doRender(Array, )
Drupal\Core\Render\Renderer->render(Array)
Drupal\Core\Template\TwigExtension->escapeFilter(Object, Array, 'html', NULL, 1)
__TwigTemplate_7a2f2d5be834da1dc0de815135d14b292e54e9c3f3d42410b7b51fff3dfc50c3->doDisplay(Array, Array)
Twig_Template->displayWithErrorHandling(Array, Array)
Twig_Template->display(Array)
Twig_Template->render(Array)
twig_render_template('core/themes/classy/templates/content-edit/node-edit-form.html.twig', Array)
Drupal\Core\Theme\ThemeManager->render(Array, Array)
Drupal\Core\Render\Renderer->doRender(Array, )
Drupal\Core\Render\Renderer->render(Array, )
Drupal\Core\Render\MainContent\HtmlRenderer->Drupal\Core\Render\MainContent\{closure}()
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object)
Drupal\Core\Render\MainContent\HtmlRenderer->prepare(Array, Object, Object)
Drupal\Core\Render\MainContent\HtmlRenderer->renderResponse(Array, Object, Object)
Drupal\Core\EventSubscriber\MainContentViewSubscriber->onViewRenderArray(Object, 'kernel.view', Object)
Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch('kernel.view', Object)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1)
Stack\StackedHttpKernel->handle(Object, 1, 1)
Drupal\Core\DrupalKernel->handle(Object)

I fixed some more places where this happens, please see if this is still an issue.