Comments

rakesh.gectcr created an issue. See original summary.

rakesh.gectcr’s picture

Category: Bug report » Task
thepanz’s picture

There is a * @return true in your patch, shouldn't it report Bool instead?

rakesh.gectcr’s picture

It is returning only, TRUE. There is no false involved in it.

thepanz’s picture

rakesh.gectcr’s picture

bool ?

thepanz’s picture

Yes, bool is the right data type to use.
If there are cases when the function does not return, you'd should add null

drunken monkey’s picture

StatusFileSize
new7.41 KB
new6.45 KB

Wow, great work, thanks a lot!

I had a few corrections and further improvements, still, but all in all this is a great step forward, thanks!
Please see my revised patch. Unless you find some issues with it, I can commit it shortly.

Right, but "True" is not a valid data type.
see: http://manual.phpdoc.org/HTMLSmartyConverter/HandS/phpDocumentor/tutoria...

Wrong, the Drupal coding standards explicitly state that true should be used in this case.
(Although the return value is pretty pointless in such a case anyways and should probably be removed.)

However, in this case it was still wrong, since the methods can also return FALSE, it was just not documented very well. (For a short time I unfortunately was a bit in love with using "iff".)

rakesh.gectcr’s picture

Status: Needs review » Reviewed & tested by the community

Looks fine for me.

drunken monkey’s picture

Status: Reviewed & tested by the community » Fixed

Great to hear.
Committed.
Thanks again for your work here!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.