In general, the strings 'id' and 'ids" are used to refer to the acronyms ID and IDs respectively. The purpose of this issue is to clean up within the migration system some of the docblocks, code comments and message strings that incorrectly reference 'id' and/or 'ids'.
In the affected files, some associated docblock fixes are also included, like the inclusion of missing '(optional)' in optional @param descriptions.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | 2609590-6-migrate-fix-string-id-d8.patch | 15.64 KB | lars toomre |
| #6 | interdiff-2609590-6-2.txt | 1.04 KB | lars toomre |
Comments
Comment #2
lars toomre commentedAlthough most of these changes are for documentation, changes to the code comments and user strings require review by the maintainers of the migration system and core committers. Attached is an initial patch with proposed changes.
Comment #3
mikeryanLooks good to me.
Comment #4
webchickThis seems like good clean-up, but not really something worth breaking strings for. Let's do this in 8.1.x instead.
Comment #5
xjmThe docs cleanups are good to go into 8.0.x, though. Can we split this patch into two parts, one that includes the docs fixes, and a followup filed against 8.1.x that includes the string change? Thanks!
Comment #6
lars toomre commentedAttached is a patch that removes the one change to a user facing message string. Also attached is an interdiff.
Comment #7
benjy commentedSuch consistency :)
Comment #8
catchCommitted/pushed to 8.1.x and cherry-picked to 8.0.x. Thanks!