Working on the documentation improvements, adding comments in code and code cleanup.

CommentFileSizeAuthor
#7 interdiff-2608898-2-7.txt379 bytesheykarthikwithu
#7 2608898-7.patch2.25 KBheykarthikwithu
#2 2608898-2.patch2.25 KBheykarthikwithu
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

heykarthikwithu created an issue. See original summary.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
CreditAttribution: heykarthikwithu as a volunteer and at Valuebound commented
Status: Active » Needs work
FileSize
2608898-2.patch2.25 KB

Added a patch with few improved on @return and @throws.

TR’s picture

TR CreditAttribution: TR commented
Status: Needs work » Needs review

Thanks. Any patches are greatly appreciated! Set the issue status to "Needs review" to get the testbot to test this and to get other people to look at your changes.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
CreditAttribution: heykarthikwithu as a volunteer and at Valuebound commented
Priority: Normal » Minor
Issue tags: +Quick fix
heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
CreditAttribution: heykarthikwithu as a volunteer and at Valuebound commented
Assigned: heykarthikwithu » Unassigned
longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave commented
Status: Needs review » Needs work

"Returns html output" should be "Returns HTML output."

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
CreditAttribution: heykarthikwithu as a volunteer and at Valuebound commented
Status: Needs work » Needs review
FileSize
2608898-7.patch2.25 KB
interdiff-2608898-2-7.txt379 bytes
longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave commented
Status: Needs review » Fixed

Committed with some further changes. Thanks for helping to improve Ubercart!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.