Modal: Close button selector not scoped to modal

It works for me.

It works for me too.
tnx!

Here's a version of this that also scopes to the .modal-header selector (since there can be elements with the "close" class in the modal body, not just the close button in the header) and makes sure to only unbind() on the correct elements (although, this is just a performance improvement, it should be harmless to unbind an event that was never bound).

We're using this patch in Panopoly.

@dsnopek your patch in #2 looked better to me. Checking the .modal-header is good though. modalContent = $('#modalContent'), though using the reference can help not parse the DOM as much.

How about:

var $modalHeader = modalContent.find('.modal-header');
$('.close', $modalHeader)


I'm not opposed to that! :-)

How's this?

I could not close modals in panels

modal.js?ocrnxd:680 Uncaught ReferenceError: $modalContent is not definedDrupal.CTools.Modal.unmodalContent @ modal.js?ocrnxd:680

Drupal.CTools.Modal.dismiss @ oa_basetheme.modal.js?ocrnxd:117Drupal.CTools.Modal.modal_dismiss @ modal.js?ocrnxd:333Drupal.ajax.success @ ajax.js?v=7.50:428success @ ajax.js?v=7.50:189c.success @ jquery.form.min.js?v=2.69:11o @ jquery.min.js?v=1.7.2:2fireWith @ jquery.min.js?v=1.7.2:2w @ jquery.min.js?v=1.7.2:4d @ jquery.min.js?v=1.7.2:4

Thanks for testing @SocialNicheGuru, I missed something it looks like. Here's the missing variable.

Patch in #11 applies cleanly to 7.x-1.x and looks good to me.

More +1 responses to #11 would be helpful (@dsnopek?), but I think this one is good to go.

Feel free to change the status to "reviewed and tested by the community" if it's working for you, that would help it get in

Proposing RTBC - slightly reluctantly because there are no 'corroborating' comments, but as far as I can see this should be a good change.

Thanks, I'm sure if the maintainers have any concern they will knock it back to needs work, so there is at least 3 people who have reviewed and tested it.

The best way to test code is to deploy code. ;)

Since this is a relatively small patch, Committed.