Payment accepts only integer quantities for line items at this moment. This can lead to undesired roundings. E.g. if the unit price is per square meter and it should be possible to order decimal quantities (e.g. 1.5 m2).
This problem has two sources. In the payment_line_item table the quantity field is of type int. And on several places in the code the quantity on a line item is type casted to an int explicitly.
The quantity field in the payment_line_item table should be of type float. Also in code the quantity should be type casted to a float.
I've fixed this problem in a local 7.x-1.15 version for a client. I'll re-roll the patch for that fix against 7.x-1.x-dev. After that I'll upload the patch here for review.
This would not affect the user interface.
This won't affect the API.
The quantity field in the payment_line_item table will be of type float instead of type int after the proposed resolution has been implemented.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | payment_2607266_4.patch | 2.34 KB | xano |
| #4 | interdiff.txt | 339 bytes | xano |
Comments
Comment #2
ricovandevin commentedThis patch should do the trick.
Comment #3
bucefal91 commentedHello!
I also upvote this issue and the patch enclosed within. Without this patch on pgsql I wasn't able even to successfully pay with "Payment" module a quantity of 1 (in PHP it was generated as float 1.00 by Commerce module and then my Postgres DB would reject the INSERT statement due to type mismatch).
Thank you for the patch, ricovandevin :) I also conducted code review and have no objections about the proposed changes in the patch.
Comment #4
xanoThanks for writing and reviewing the patch! I fixed one default value that was still an integer. Otherwise this is good to go.
Comment #5
xanoThe tests will not pass on PHP 7 because of #2554339: Plan for CTools 7.x-1.10 release. The maintainers have been contacted about this.
Because the tests pass on PHP 5.6, I will commit this. Thanks for the work!
Comment #7
bucefal91 commentedThanks! :)