Scald does not assign the result of .find('img') when a parent element of the image is dragged and thus fails to determine the atom ID.

By the way, the variable "id" gets declared twice (not fixed by the patch).

CommentFileSizeAuthor
#5 scald-dnd_drag_parent-2606360-5.patch869 bytesnagy.balint
#2 scald-dnd_drag_parent-2606360-2.patch740 bytesciss

Comments

ciss created an issue. See original summary.

ciss’s picture

ciss commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new scald-dnd_drag_parent-2606360-2.patch740 bytes

Patch against 164db05 (2014-11-27, version 1.2 + 32 commits). Different offset in HEAD.

ciss’s picture

ciss commented
Issue summary: View changes

Added more details to summary.

Status: Needs review » Needs work

The last submitted patch, 2: scald-dnd_drag_parent-2606360-2.patch, failed testing.

nagy.balint’s picture

nagy.balint commented
Version: 7.x-1.2 » 7.x-1.6
Status: Needs work » Needs review
StatusFileSize
new scald-dnd_drag_parent-2606360-5.patch869 bytes

Thanks!

I also removed the id double declaration as anyways that will be overriden.

More testing is required though.

nagy.balint’s picture

nagy.balint commented
Status: Needs review » Fixed

Cant see anything wrong with this patch, committed.

  • nagy.balint committed 3e5cc17 on 7.x-1.x authored by ciss 
    Issue #2606360 by ciss, nagy.balint: Dragging fails when img parent...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.