Replace format_date() with service

1. +++ b/src/Form/SchedulerAdminForm.php
   @@ -35,7 +35,8 @@ class SchedulerAdminForm extends ConfigFormBase {
   -    $now = t('Example: %date', ['%date' => format_date(REQUEST_TIME, 'custom', \Drupal::config('scheduler.settings')->get('date_format'))]);
   +    $date_formatter = \Drupal::service('date.formatter');
   

   should use DI

2. +++ b/src/Form/SchedulerAdminForm.php
   @@ -88,6 +89,7 @@ class SchedulerAdminForm extends ConfigFormBase {
   +    $date_formatter = \Drupal::service('date.formatter');
        // Replace all contiguous whitespaces (including tabs and newlines) with a
   

   should use DI

+++ b/src/Form/SchedulerAdminForm.php
@@ -18,6 +20,31 @@ use Drupal\Core\Url;
+  /**
+   * Creates a SchedulerAdminForm.
+   *

object / instance

It is good practice to call the parent constructor but in this case you don't need this. See ConfigFormBaseTrait

Re-rolled patch and removed call to parent constructor as mentioned in #11.

Last patch is corrupt:

$ curl -s https://www.drupal.org/files/issues/replace_format_date-2606248-12.patch | git apply --index
fatal: corrupt patch at line 228

This is because of the commits in other issues since I created it - patch re-rolled :)

Forgot to remove config.factory from create() which caused a fatal error in the tests.

1. +++ b/src/Form/SchedulerAdminForm.php
   @@ -7,9 +7,12 @@
    
   +use Drupal\Core\Config\ConfigFactoryInterface;
   

   Now not required

2. +++ b/src/Form/SchedulerAdminForm.php
   @@ -17,6 +20,32 @@ use Drupal\Core\Url;
   +  /**
   +   * {@inheritdoc}
   +   *
   

   should be like 'Creates instance/object of ***'

3. +++ b/src/Form/SchedulerAdminForm.php
   @@ -35,7 +64,7 @@ class SchedulerAdminForm extends ConfigFormBase {
   -    $now = $this->t('Example: %date', ['%date' => \Drupal::service('date.formatter')->format(REQUEST_TIME, 'custom', $config->get('date_format'))]);
   +    $now = t('Example: %date', ['%date' => $this->dateFormatter->format(REQUEST_TIME, 'custom', $config->get('date_format'))]);
        $url = Url::fromUri('http://php.net/manual/en/function.date.php');
   

   shouldn't be this->t

Patch updated - thanks for the feedback joshi.rohit100.

looks fine to me now. Please try to upload the interdiff as well as it makes the review easy :)

Nice work, thanks a lot gentlemen, and a happy new year!

Ignore the failed patches above. They were queued but not run until the 8.x committed codebase passed all tests. That happened with my commit a few minutes ago, and then the untested patches have suddenly come to life and been run. This issue is already fixed and closed.