In the file : core/lib/Drupal/Core/DrupalKernel.php has comment typos.

The following is the changes,

-   *   TRUE if the hostmame is valid, or FALSE otherwise.
+   *   TRUE if the hostname is valid, or FALSE otherwise.
-   * Host patterns (as regular expressions) can be configured throught
+   * Host patterns (as regular expressions) can be configured through
    * settings.php for multisite installations, sites using ServerAlias without
CommentFileSizeAuthor
#14 2605388-14.patch1.16 KBaneeshthankachan
#9 interdiff-2605388-7-9.txt1.09 KBanil280988
#9 2605388-9.patch2.04 KBanil280988
#7 2605388-6.patch1.16 KBmahaveer003
#4 typo-drupal-kernal-2.patch1.35 KBrakesh.gectcr
#4 interdiff-2605388-1-2.txt1.43 KBrakesh.gectcr
typo-drupal-kernal-1.patch2.3 KBrakesh.gectcr
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rakesh.gectcr created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave commented
Status: Needs review » Needs work

Reinject and reinstantiated, while uncommon in English, look correct to me. The last two changes are good though.

sushantpaste’s picture

sushantpaste
Primary language Marathi
Location Sawantwadi India
CreditAttribution: sushantpaste at OSSeed Technologies commented

Patch works fine but I think Reinject (this is also used in core/lib/Drupal/Core/Config/ConfigImporter.php) and reinstantiated are looks correct.

rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language Malayalam
Location Manchester
CreditAttribution: rakesh.gectcr as a volunteer and at Valuebound commented
FileSize
interdiff-2605388-1-2.txt1.43 KB
typo-drupal-kernal-2.patch1.35 KB

I removed the both Reinject and reinstantiated .

rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language Malayalam
Location Manchester
CreditAttribution: rakesh.gectcr as a volunteer and at Valuebound commented
Issue summary: View changes
Status: Needs work » Needs review
mahaveer003’s picture

mahaveer003 CreditAttribution: mahaveer003 at Valuebound commented
Status: Needs review » Needs work

@rakesh.gectcr, Looks like you have added the wrong patch.

You have added the namespace with this

mahaveer003’s picture

mahaveer003 CreditAttribution: mahaveer003 as a volunteer and at Valuebound commented
FileSize
2605388-6.patch1.16 KB 
    * @return bool
-   *   TRUE if the hostmame is valid, or FALSE otherwise.
+   *   TRUE if the hostname is valid, or FALSE otherwise.
-   * Host patterns (as regular expressions) can be configured throught
+   * Host patterns (as regular expressions) can be configured through
    * settings.php for multisite installations, sites using ServerAlias without
mahaveer003’s picture

mahaveer003 CreditAttribution: mahaveer003 as a volunteer and at Valuebound commented
Status: Needs work » Needs review
anil280988’s picture

anil280988 CreditAttribution: anil280988 at Publicis Sapient for Publicis Sapient commented
FileSize
2605388-9.patch2.04 KB
interdiff-2605388-7-9.txt1.09 KB

Number of characters exceeds 80 in 1st line. Added patch for this

// Identify all services whose instances should be persisted when rebuilding
// the container during the lifetime of the kernel (e.g., during a kernel
// reboot). Include synthetic services, because by definition, they cannot
// be automatically reinstantiated. Also include services tagged to persist.

The last submitted patch, 7: 2605388-6.patch, failed testing.

sushantpaste’s picture

sushantpaste
Primary language Marathi
Location Sawantwadi India
CreditAttribution: sushantpaste at OSSeed Technologies commented

#9 Patch works fine.

sushantpaste’s picture

sushantpaste
Primary language Marathi
Location Sawantwadi India
CreditAttribution: sushantpaste at OSSeed Technologies commented
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 9: 2605388-9.patch, failed testing.

aneeshthankachan’s picture

aneeshthankachan CreditAttribution: aneeshthankachan as a volunteer and at Valuebound commented
Status: Needs work » Needs review
FileSize
2605388-14.patch1.16 KB

I recreated the patch. Only having the typo Fix

cilefen’s picture

cilefen CreditAttribution: cilefen commented
Status: Needs review » Reviewed & tested by the community

There is not much to say.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.0.x, thanks!

  • catch committed 099d11a on 8.0.x 
    Issue #2605388 by rakesh.gectcr, anil280988, mahavir003,...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.