When using Display Suite 8.x-2.x dev the field ui breaks on display suite fields inside the field groups.

Comments

danielbeeke created an issue. See original summary.

danielbeeke’s picture

StatusFileSize
new1.4 KB

I think this is a bit quick and dirty, I would like to hear how we can create this functionality in a clean way.
After critics I would like to create a new patch.

danielbeeke’s picture

Assigned: Unassigned » danielbeeke
Status: Needs review » Needs work

I will fix another patch this evening, and test for use with fieldgroup and without fieldgroup.

danielbeeke’s picture

Status: Needs work » Needs review
StatusFileSize
new2.32 KB

I don't know how, but the previous patch did not include the adding of the field group preprocess function, and it seem to work. Maybe the code should be inside the field group module. The reason why I did it here is that I think that field group doesn't need to know all the different layouts of ds, but maybe there is a better way.

In this patch is also a fix for variants on templates, see:
https://www.drupal.org/node/2594123

If I need to create two patches, one for each issue, please let me know.

aspilicious’s picture

Related fieldgroup issue: https://www.drupal.org/node/2557877

bceyssens’s picture

Status: Needs review » Closed (fixed)

Thank you for your patch @danielbeeke.
It works perfectly together with field_group patch #2557877: Fields are not grouped when render element key is not elements

The last submitted patch, 2: fieldgroup-compatibility-2604994-2.patch, failed testing.

Status: Closed (fixed) » Needs work
aspilicious’s picture

Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.