Add @param and removal of unused variables in the code.

CommentFileSizeAuthor
#2 2604868.patch3.13 KBheykarthikwithu

Comments

heykarthikwithu created an issue. See original summary.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Status: Active » Needs review
StatusFileSize
new 2604868.patch3.13 KB

added a patch for this.

eugene.ilyin’s picture

eugene.ilyin commented

Thank you for your notices. Committed.

  • eugene.ilyin committed 0da3af1 on 7.x-1.x 
    Issue #2604868 by heykarthikwithu: Add @param and removal of unused...
eugene.ilyin’s picture

eugene.ilyin commented
Status: Needs review » Fixed
xumepadismal’s picture

xumepadismal commented

It seems that commit a bit differs from the patch and it actually breaks my site. These are the problem lines...

-      $facet_info[$name]['map options']['value callback'] = '_date_facets_api_facet_create_label';
+      $facet_info[$name]['map options']['value callback'] = 'date_facets_tabledrag_form_validate';

I guess we should revet these lines or?

eugene.ilyin’s picture

eugene.ilyin commented

Yes it's looks like error. I don't know how it happened. Thank you for this catch. I'll commit it soon.

  • eugene.ilyin committed da9953a on 7.x-1.x 
    Issue #2604868 by heykarthikwithu, eugene.ilyin, xumepadismal: Add @...
eugene.ilyin’s picture

eugene.ilyin commented

Committed. Thank you.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.