Code cleanup: Remove unused variables throughout the module

removed the unused variables in the code, added a patch for this.

yes this was tested, and this was a manual review of code, any how using a IDE for to do this.

 function _webform_render_email($component, $value = NULL, $filter = TRUE, $submission = NULL) {
-  global $user;
   $node = isset($component['nid']) ? node_load($component['nid']) : NULL;

$user variable is not used anymore inside the function.

   foreach (element_children($element['types']) as $filtergroup) {
-    $row = array();
-    $first_row = count($rows);
     if ($element['types'][$filtergroup]['#type'] == 'checkboxes') {

$row and $first_row variables are not used anymore inside the function.

-  $component = $element['#webform_component'];
   $format = $element['#format'];

$component is not used anymore inside the fucntion.

-  foreach ($element['#grid_questions'] as $question_key => $question) {
+  foreach ($element['#grid_questions'] as $question) {

$question_key is not used inside the foreach loop.

-    foreach ($value as $key => $option_value) {
+    foreach ($value as $option_value) {

$key is not used inside the foreach loop.

 function webform_validate_time($element, $form_state) {
-  $form_key = $element['#webform_component']['form_key'];

$form_key varible is not used in the function.

 function theme_webform_components_page($variables) {
-  $node = $variables['node'];
   $form = $variables['form'];

$node variable is not used inside the function.

-    foreach ($duplicates as $form_key => $cids) {
+    foreach ($duplicates as $cids) {

$form_key variable is not more used inside the function.

-  foreach ($node->webform['components'] as $cid => $component) {
+  foreach ($node->webform['components'] as $component) {

$cid is not used inside the foreach loop.

-  $query = db_insert('webform_component')
+  db_insert('webform_component')

$query variable is not used anymore in further code, so this can be removed.

-    $delete_conditional = FALSE;
     $specs = array(

$delete_conditional variable is not used inside the function.

-    foreach ($node->webform['components'] as $cid => $child_component) {
+    foreach ($node->webform['components'] as $child_component) {

-  foreach ($form_state['values']['conditionals'] as $key => $conditional) {
+  foreach ($form_state['values']['conditionals'] as $conditional) {

$cid and $key variables are no more used inside the foreach.

   $parents = $button['#parents'];
-  $action = array_pop($parents);

$action variable is not used in further code.

 function webform_email_delete_form($form, $form_state, $node, $email) {
-  $eid = $email['eid'];

$eid variable is no more used inside the fucction.

-  $components = $variables['components'];
   $submissions = $variables['submissions'];
   $total_count = $variables['total_count'];
   $pager_count = $variables['pager_count'];
 
-  $header = array();

$components and $header variable are no more used inside the fucntion.

-  foreach ($submissions as $sid => $submission) {
+  foreach ($submissions as $submission) {

$sid variable is not used in the foreach.

   $data = $variables['data'];
-  $sids = $variables['sids'];
   $analysis_component = $variables['component'];

$sids variable is no more used inside the function.

-  foreach ($emails as $eid => $email) {
+  foreach ($emails as $email) {

-      foreach ($conditional['actions'] as $aid => $action) {
+      foreach ($conditional['actions'] as $action) 

$eid and $aid variables are not used inside the foreach.

         $conditional = $conditionals[$conditional_spec['rgid']];
-        $conditional_result = TRUE;

 function webform_views_autocomplete($string = '') {
-  $matches = array();

$conditional_result and $matches variables are no more used inside the function.

-          foreach ($submission_node->webform['components'] as $sub_cid => $sub_component) {
+          foreach ($submission_node->webform['components'] as $sub_component) 

-    foreach ($this->submissions as $sid => $submission) {
+    foreach ($this->submissions as $submission) {

-  foreach ($items as $key => $item) {
+  foreach ($items as $item) {

-  foreach ($options['components'] as $key => &$component) {
+  foreach ($options['components'] as &$component) {

-    foreach ($node->webform['components'] as $cid => $component) {
+    foreach ($node->webform['components'] as $component) {

-    foreach ($node->webform['components'] as $cid => $component) {
+    foreach ($node->webform['components'] as $component) {

-    foreach ($node->webform['emails'] as $eid => $email) {
+    foreach ($node->webform['emails'] as $email) {

-  foreach ($node->webform['components'] as $cid => $component) {
+  foreach ($node->webform['components'] as $component) {

$sub_cid, $sid, $key, $cid, $eid, $cid variables are no more used inside their foreach loops.

 function webform_block_view($delta = '') {
-  global $user;

 function webform_client_form_prevalidate($form, &$form_state) {
-  global $user;

$user varible is no more used inside the function.

-  foreach ($text_tokens as $type => $tokens) {
+  foreach ($text_tokens as $tokens) {

-  foreach ($node->webform['components'] as $cid => $component) {
+  foreach ($node->webform['components'] as $component) {

-    foreach ($node->webform['components'] as $cid => $component) {
+    foreach ($node->webform['components'] as $component) {

$type, $cid variables are no more used inside the foreach.

Checked manually by debugging the code where all i found the unused variables, and confirmed the few variables are no more used inside the function.