Problem/Motivation

Some SensorPlugins have a hardcoded raw php function to formate the date.

Proposed resolution

Use Drupal's format date API instead.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 use_drupal_s_format-2603272-5.patch3.83 KBedurenye

Comments

edurenye created an issue. See original summary.

edurenye’s picture

edurenye commented
Parent issue: » #2601424: Readd timestamp for all watchdog sensors
miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented

The issue clashes also with #2581775: Fatal error when deleting a user. Add verbose table of deleted users.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented

The other issue got committed. Please fix all the dates in verbose output.

edurenye’s picture

edurenye commented
Title: Use Drupal's format date API in DatabaseAggregatorSensorPlugin » Use Drupal's format date API in some SensorPlugins
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new use_drupal_s_format-2603272-5.patch3.83 KB

Fixed all cases, that was WatchdogAggregatorSensorPlugin and UserIntegritySensorPlugin.

edurenye’s picture

edurenye commented
Title: Use Drupal's format date API in some SensorPlugins » Use Drupal's format date API in all the SensorPlugins
miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs review » Fixed

Committed, thx.

Followup: I think we should add a test where we check the date output... We can use the fake log records that we already write. Put a date there and check their corresponding date on the output.

edurenye’s picture

edurenye commented

Created the followup: #2604784: Add a test to check the date output

Status: Fixed » Needs work

The last submitted patch, 5: use_drupal_s_format-2603272-5.patch, failed testing.

giancarlosotelo’s picture

giancarlosotelo commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.