Closed (fixed)
Project:
Monitoring
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
26 Oct 2015 at 16:27 UTC
Updated:
11 Nov 2015 at 08:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
miro_dietikerStrangely the watchdog sensor has special treatment to convert the timestamp from the epoch seconds to a readable format...
But it seems when we did the most recent refactoring, we accidentally dropped force adding the timestamp column...
Anyway, that's supposed to happen in config since it's a visible column.
In contrast to other columns that are force added by code and then not displayed at all. These should not be added by config at all IMHO.
We should check all sensors of Watchdog and unify the verbose columns as much it makes sense.
Followup: We also looked at a DatabaseAggregator that also had a timestamp added where the output is not converted at all...
Dunno how we can make sure we take care of the format / visual conversion for regular columns. For now our config schema does not support it.
Comment #3
miro_dietikerTrying some first cleanup...
(Additionally improved some comments / code sequence in the watchdog code where the timestamp handling takes place.)
Comment #5
miro_dietikerAww, forgot to flip some columns. Fixed and committed. There's still a failing test from SearchAPI.
Comment #7
berdirwhy hardcode this using raw php functions instead of using Drupal's format date API's (which can be translated and configured)?
Was there before as I see, can someone open a follow-up to improve that?
Comment #8
edurenye commentedDone. #2603272: Use Drupal's format date API in all the SensorPlugins