Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
search.module
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
27 Oct 2015 at 12:44 UTC
Updated:
17 Nov 2015 at 11:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
heykarthikwithuComment #3
heykarthikwithuComment #4
jhodgdonThis is correct. That local variable is indeed never used, and the return docs are correct. Should be rc eligible because it is just removing one line of cruft and adding API docs.
Fixing issue title though, since the patch is just adding the missing return type to the function docs, not fixing some incorrect docs.
Comment #6
heykarthikwithuComment #7
heykarthikwithuMoving back to RTBC, since status was updated by BOT.
Comment #8
jhodgdonPatch #5 is not quite right. It is missing the |null from the other patch in the return line... and the other patch I just noticed should be |null not |NULL in the @return line.
Comment #9
anil280988 commentedChanged NULL to null
Comment #10
jhodgdonThanks! All correct now. Adding RC note to issue summary.
Comment #12
anil280988 commentedOn of the Test is aborted, its happening with other patches also. Could you suggest how to handle this.
Comment #13
rakesh.gectcrRecreated the new patch with exactly same changes.
Comment #14
rakesh.gectcrThe test is passed now, Keeping back to RTBC
Comment #15
jhodgdonThanks! Hm. there used to be a "retest" button.... I guess that doesn't exist in the current test environment.
Anyway you probably could have just set the status back to RTBC and the test would have eventually been re-run. Next time. :)
Comment #17
jhodgdonSomeone keeps aborting tests on the bot and that is causing issues to get set to Needs Work. We need to fix that. Anyway this is still RTBC.
Comment #19
catchCommitted/pushed to 8.0.x, thanks!