Removal of unused variable CommentController::getReplyForm(Request $request, EntityInterface $entity, $field_name, $pid = NULL)

CommentFileSizeAuthor
#2 2600996.patch634 bytesheykarthikwithu
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

heykarthikwithu created an issue. See original summary.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
CreditAttribution: heykarthikwithu as a volunteer and at Valuebound commented
Status: Active » Needs review
FileSize
2600996.patch634 bytes
heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
CreditAttribution: heykarthikwithu as a volunteer and at Valuebound commented
Issue tags: +rc eligible
heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
CreditAttribution: heykarthikwithu as a volunteer and at Valuebound commented
Priority: Normal » Minor
cilefen’s picture

cilefen CreditAttribution: cilefen commented
Status: Needs review » Reviewed & tested by the community

There is not much to say here - the variable is unused in the method.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
CreditAttribution: heykarthikwithu as a volunteer and at Valuebound commented

yes @cilefen, a minor one thanks.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Yep the variable is unused and the methods called don't affect global state. Committed ae32878 and pushed to 8.0.x. Thanks!

  • alexpott committed ae32878 on 8.0.x 
    Issue #2600996 by heykarthikwithu: Removal of unused variable...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.