Needs review
Project:
Webform2PDF
Version:
7.x-4.x-dev
Component:
Code
Priority:
Minor
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
20 Oct 2015 at 13:45 UTC
Updated:
16 Apr 2024 at 14:01 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
ahmed_samir commentedComment #3
tclark62 commentedThis patch fixed the errors I was getting:
Now the email which is checked no longer receives a PDF.
However, now I receive two new notices:
For some reason it's attempting to pass through more variables than the array has. I added a dummy email address to not be sent an email, so that it has enough not to through this notice, but this should be incorporated in the patch. (I would, but my php is very weak so I can't detect exactly where it's going wrong.)
Comment #4
tclark62 commentedComment #5
roderik de langen commentedThis is not working when 2 emails are sent out to the same addres.
Any ideas how this could be done?
Comment #6
tclark62 commentedThere are still issues with the completeness of this patch. Should have set this status previously.
Comment #7
eric115 commentedDid some more work on the patch, this fixes this issue for me. Please review :)
Comment #8
eric115 commentedWhoops, the array_map can be moved outside of the loop now.
Comment #9
tclark62 commentedI went to test this patch, but for some reason the files needed to patch for both this issue and another issue related to webform2pdf aren't present. In both 4.0 and 4.x-dev of Webform, I'm missing webform2pdf.theme.inc and webform2pdf.mail.inc. Do you know of any reason for this?
Comment #10
eric115 commented@tclark62, I checked my patch again, but it looks like it's patching the right file and the files definitely exist in the 4.x branch (http://cgit.drupalcode.org/webform2pdf/tree/includes) - are you sure you have an unchanged version of webform2pdf? Could you try downloading a fresh copy of the module and trying to apply the patch again, just in case? Also, make sure you are applying this patch to the webform2pdf module, not the webform module.
Comment #11
DependencyHell commentedPatch #8 for this issue is not working with an email field allowing multiple values
Patch #11 is not working with empty (optionals) email fields (Current version is showing warnings)
Comment #12
yanyong commentedI run into the same issues. Here is my fix.
Comment #13
IowaBoy commentedI just used yanyong's patch #12 and it worked for me
Comment #14
sethfisher commentedThis patch works for me