Closed (fixed)
Project:
Leaflet Widget for Geofield
Version:
7.x-2.0-beta1
Component:
Code
Priority:
Critical
Category:
Plan
Assigned:
Unassigned
Reporter:
Created:
20 Oct 2015 at 03:42 UTC
Updated:
15 Feb 2019 at 14:44 UTC
Jump to comment: Most recent
Comments
Comment #2
tema commentedThat fork was for Geofield 1.x only.
Here's another one with 2.x support: https://github.com/chrsnlsn/leaflet-widget-point
Comment #3
das-peter commentedUnfortunately it's unlikely that I can invest time in leaflet as we decided to go with OpenLayers 3.x last year. And currently there's no other project in sight where I could justify to spend time on this module.
Comment #4
robertwb commentedWhat say move the project status to "Seeking New Maintainer" and dev status to "Minimally Maintained" or something? @tema - is there any reason for a fork, as opposed to requesting to be made project maintainer?
Comment #5
das-peter commentedDone.
I also checked my project permission, I should be able to add new maintainers ;)
Comment #6
robertwb commentedI wont speak for @tema, but seems like the motivation might be there :)
For myself, I would submit a request for maintainership, but my resume for this module is NULL - though I do have one crappy (but useful) patch I threw up yesterday, if anyone wanted to try it out and see if it was worth committing - I would volunteer :) .
Comment #7
tema commented@das-peter, OpenLayers module is an overkill for my needs. Also 7.x-3.x seems a horrible D8 backport with a lot of dependencies. I gave it a try, it doesn't work out-of-the-box for my setup. But 7.x-2.x is boring :\
@robertwb, that forks are not mine, you may ask that guys on GitHub if they're interesting to be maintainers here. As for me, I looked for something "easy and working" (that's what everyone does here, eventually).
I tried leaflet-widget-point, it's much simpler (but works), maybe I'll settle for it. Also I copy/pasted leaflet-control-geocoder integration from here: https://github.com/bforchhammer/leaflet_search (D8 module), the result is here: https://github.com/ArtemT/leaflet-widget-point/tree/leaflet-control-geoc....
As for leaflet_draw_widget, it's a fork of leaflet_widget-7.x-1.x. I tried to hack it for geofield-7.x-2.x support, with no luck. Maybe you'll try, @robertwb?
Comment #8
robertwb commented@tema - thanks for the response. FWIW I am successfully using this module with no patches (well 1, but it's elective - see above), with Geofield 7.x-2.3 -- I only need to draw polygons and points, so perhaps my case is not testing hidden issues. If you have a specific bug report, file it, or if it's already filed , relate here so it can be looked at.
FWIW - the Leaflet Widget is only one mode for Leaflet in Drupal, the field editing portion. A lot of work lately has been done by myself and others in the Leaflet queue (which provides display widget, Views field, and Views display options for Leaflet maps) and Leaflet GeoJSON which adds panels display config and rendering in addition to the performance advantage of filtering remote geojson elements based on the view extent, and refreshing on pan and zoom. In short, Leaflet is alive and well, still nice and simple, and with good performance.
For the time being I am going to slog through the issue queue here since I am in the midst of some edit widget implementations -- if I feel like I'm up to taking over maintenance I will definitely request permissions.
Comment #9
fmb commentedI am offering to co-maintain this module, mostly the D8 branch, as stated in #2654864: Port to Drupal 8.
Comment #10
fmb commentedComment #11
Joel MMCC commented@FMB, I offer my code for suggested improvements to the Leafet Widget-Point sandbox module, to be incorporated into this one, or not, as you and the other maintainers see fit. See this Issue: #2950605: HTML5 Geolocation (GPS) — implemented!.
To all: as it turns out, there’s another Leaflet add-on library for editing geometry on a map, called Leaflet.Editable as opposed to Leaflet.Widget. It seems to have some advantages. It’s one of the main differences between the older, deprecated geojson.io and the similar, newer (but currently non-functional for unrelated reasons — hopefully will be fixed soon) geojson.net by the same developer and which is intended to replace the former. Maybe Drupal could use a “Leaflet.Editable for Geofield” module that uses that library instead of Leaflet.Widget?
Comment #12
fmb commentedI was recently given maintainers rights for this project. I published a Drupal 8 release (#2654864: Port to Drupal 8). I do not have much time left this month, but next month I think I will publish a new release for Drupal 7. So in a nutshell, yes, this module is still being maintained.
Joel MMCC: could you elaborate on the features present in your Leaflet Widet-Point module which according to you should or could be brought to Leaflet Widget for Geofield? Same for Leaflet.Editable & Co. I would appreciate this were reported in one (or more) new issue(s) (feature request), thanks!
Comment #13
Joel MMCC commented@FMB, Leaflet-WidgetPoint is a sandbox module by another developer. I improved it a lot, as described in the Issue #2950605: HTML5 Geolocation (GPS) — implemented! as stated before. That Issue includes my actual code changes.
Leaflet-Widget-Point is a sandbox module (by “chrsnlsn”) that is similar to Leaflet-Widget except that it’s by design limited to entry of a single point coordinate, which is useful for underlying fields where that is the desired input (no linestrings or polygons or even multipoints). Rather than letting the user place a marker, it instead draws crosshairs in the middle of the map and allows the user to slide the map around with mouse or touch-drag-pinch-zoom until the desired point is centered in the crosshairs. Wherever the crosshairs are centered at the time the Entity Add or Edit form is submitted, that’s the latitude / longitude pair that will be stored in the underlying field.
What I did was (among other things) implemented the
leaflet-locatecontrollibrary, which allows HTML5 geolocation to work. I set it by default so that the geolocate is triggered automatically when Adding an Entity, but not when Editing one (since that could easily accidentally overwrite a carefully placed coordinate from before — one change I might like to add would be to also allow it to trigger on Edit if and only if the underlying field has no value at the time of the Edit). I also provided for manual triggering of the locate if desired, and per-instance configurations of several options not available before.I could see something similar implemented here, with the ability to geolocate and optionally place a marker at the current geolocated position, yet still be able to draw linestrings and polygons and additional point-markers as desired.
As for Leaflet.Editable, that’s just an alternative library to Leaflet.Draw (not Leaflet.Widget as I erroneously stated before). It seems to be more forward-thinking.
I’m not yet familiar enough with PHP and Drupal and LAMP development in general. My software development experience has been in WISA. But I’m trying to learn. I have the NetBeans 8.x IDE with Drupal extensions running on Windows, and a VM. I still haven’t figured out how to coax NetBeans into exporting a proper .patch for an entire directory such as a module directory. It only makes them for single files, so I haven’t been able to contribute proper patches yet unless they’re just for a single file.
Comment #14
ken-g commentedHi Felip,
I was delighted to see that someone (ie. you) had offered to take on the role of maintainer for this module. The Drupal site that I help maintain wanted the ability to create and maintain geometries on a Leaflet map, and because there had been no development on this module in over 4 years, we ended up writing a custom module based on an out-of-date version of this module.
Now that we have got it working on our own site, I would like to assist you in adding the same kind of functionality back into this module. I would like to focus on Drupal 8, but if it helps there is no reason why we shouldn't backport the same functionality to Drupal 7 as well if there is still interest.
So, if it is OK with you, I will start raising a number of Feature Requests as Issues against the D8 version you created at the start of January. My intention is then to provide you with a series of patches that address some of the D7/D8 issues on the Issues List that have been raised over months/years.
In summary, this module has the potential to be THE widget for editing Geofield using a Leaflet Map in both D7/D8 - it just needs a bit of love and attention !!
Comment #15
fmb commentedJoel: this should really go into a new issue, thanks.
Ken: sure, thanks for your offer. Feel free to open new feature requests.