Found couple of comment Typos in the '/core/includes/bootstrap.inc' file

CommentFileSizeAuthor
#20 issueno-2594441-commentno-18.patch1.24 KBrakesh.gectcr
#13 issueno-2594441-commentno-12.patch1.31 KBrakesh.gectcr
#11 issueno-2594441-change-the-@return-and-compatibile-typo-commentno-10.patch1.31 KBrakesh.gectcr
#8 issueno-2594441-commentno-8.patch2.52 KBrakesh.gectcr
#7 interdff-7.txt808 bytesjoshi.rohit100
#7 2594441-7.patch1009 bytesjoshi.rohit100
#4 drupal-8.0.x-typos-2594441-4.patch1.3 KBnitesh pawar
#3 drupal-8.0.x-typos-issueno-2594441-commentno-10456665.patch1.11 KBrakesh.gectcr

Comments

rakesh.gectcr created an issue. See original summary.

rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language English
Location Manchester
commented
Issue summary: View changes
rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language English
Location Manchester
commented
Status: Active » Needs review
StatusFileSize
new drupal-8.0.x-typos-issueno-2594441-commentno-10456665.patch1.11 KB

Please review the patch

nitesh pawar’s picture

nitesh pawar commented
StatusFileSize
new drupal-8.0.x-typos-2594441-4.patch1.3 KB

New Patch on latest revision

cilefen’s picture

cilefen commented
Status: Needs review » Needs work 
  1. +++ b/core/includes/bootstrap.inc
@@ -578,11 +578,11 @@ function _drupal_exception_handler($exception) {
   // PHP 7 introduces Throwable, which covers both Error and
-  // Exception throwables.
+  // Exceptions throwable.

    I do not think this is a typo. The throwables are Error and Exception. 

  2. +++ b/core/includes/bootstrap.inc
@@ -994,11 +994,11 @@ function _drupal_shutdown_function() {
   // PHP 7 introduces Throwable, which covers both Error and
-  // Exception throwables.
+  // Exceptions throwable.
   catch (\Throwable $error) {

    Also, this is not a typo.

cilefen’s picture

cilefen commented
Issue tags: -typos +Novice, +rc eligible
joshi.rohit100’s picture

joshi.rohit100
he/him
Primary language Hindi
Location Delhi, India
commented
Status: Needs work » Needs review
StatusFileSize
new 2594441-7.patch1009 bytes
new interdff-7.txt808 bytes
rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language English
Location Manchester
commented
StatusFileSize
new issueno-2594441-commentno-8.patch2.52 KB
cilefen’s picture

cilefen commented 
+++ b/core/includes/bootstrap.inc
@@ -348,10 +348,8 @@ function format_string($string, array $args) {
- *
- * @return
- *   TRUE if the text is valid UTF-8, FALSE if not.
- *
+ * @return bool TRUE if the text is valid UTF-8, FALSE if not.
+ * TRUE if the text is valid UTF-8, FALSE if not.

This looks like a typo.

rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language English
Location Manchester
commented

@cilefen

It is there in the latest pull .

Is it better to keep like following.

* @return bool
- *   TRUE if the text is valid UTF-8, FALSE if not.
rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language English
Location Manchester
commented
StatusFileSize
new issueno-2594441-change-the-@return-and-compatibile-typo-commentno-10.patch1.31 KB

Change the 'compatibile typo compatible' and added the @return with bool

Status: Needs review » Needs work

The last submitted patch, 11: issueno-2594441-change-the-@return-and-compatibile-typo-commentno-10.patch, failed testing.

rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language English
Location Manchester
commented
StatusFileSize
new issueno-2594441-commentno-12.patch1.31 KB
rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language English
Location Manchester
commented
Status: Needs work » Needs review

The last submitted patch, 11: issueno-2594441-change-the-@return-and-compatibile-typo-commentno-10.patch, failed testing.

snehi’s picture

snehi commented
Status: Needs review » Reviewed & tested by the community

looks RTBC to me.

The last submitted patch, 11: issueno-2594441-change-the-@return-and-compatibile-typo-commentno-10.patch, failed testing.

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

Thanks for the patch!

+++ b/core/includes/bootstrap.inc
@@ -348,10 +348,8 @@ function format_string($string, array $args) {
- *
- * @return
+ * @return bool
...
- *
  * @see \Drupal\Component\Utility\Unicode::validateUtf8()

These blank lines should actually not be removed per our standard. Reference: https://www.drupal.org/node/1354#drupal

rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language English
Location Manchester
commented
Assigned: Unassigned » rakesh.gectcr
rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language English
Location Manchester
commented
StatusFileSize
new issueno-2594441-commentno-18.patch1.24 KB
rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language English
Location Manchester
commented
Status: Needs work » Needs review
rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language English
Location Manchester
commented

@xjm

I have fixed that in the latest patch, Please review it

The last submitted patch, 11: issueno-2594441-change-the-@return-and-compatibile-typo-commentno-10.patch, failed testing.

cilefen’s picture

cilefen commented
Status: Needs review » Reviewed & tested by the community

@rakesh.gectcr Nice work. Next time, please provide an interdiff. It saves the reviewers' time.

The last submitted patch, 11: issueno-2594441-change-the-@return-and-compatibile-typo-commentno-10.patch, failed testing.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 3b8efbf and pushed to 8.0.x. Thanks!

  • alexpott committed 3b8efbf on 8.0.x 
    Issue #2594441 by rakesh.gectcr, joshi.rohit100, Nitesh Pawar, cilefen,...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.