on the /admin/config/media/colorbox page:

Advanced Settings

Mobile detection
On
Off
If on (default) Colorbox will not be active for devices with a the max width set below.

Emphasis is on the incorrect verbiage.

Maybe read "devices with the max width" or "devices with a max width" Looks like a simple oversight to me.

I apologize for not being able to create a proper patch, that is beyond my skill level.

CommentFileSizeAuthor
#3 Colorbox-Fixed_typo_on_admin_settings-2593101-3.patch995 bytesnupur.lohokare

Comments

philsward created an issue. See original summary.

nupur.lohokare’s picture

nupur.lohokare commented
Assigned: Unassigned » nupur.lohokare
nupur.lohokare’s picture

nupur.lohokare commented
Assigned: nupur.lohokare » Unassigned
Status: Active » Needs review
StatusFileSize
new Colorbox-Fixed_typo_on_admin_settings-2593101-3.patch995 bytes

Hi philsward,

Found the issue you mentioned and modified the message to -
'If On (default), Colorbox will not be active for devices with the max width set below.'

Thanks
Nupur

gaurav.bajpai’s picture

gaurav.bajpai commented
Status: Needs review » Reviewed & tested by the community

Hi nupur.lohokare,

I checked your patch and looks good.

Thanks,
Gaurav

philsward’s picture

philsward commented

Applied nupur.lohokare patch with no errors. Looks good to me too.

  • frjo committed a14430a on 7.x-2.x authored by nupur.lohokare 
    Issue #2593101 by nupur.lohokare, philsward: Typo in Colorbox Admin...
frjo’s picture

frjo commented
Status: Reviewed & tested by the community » Fixed

Committed to 7.x-2.x.

Thank you for helping to improve the Colorbox module!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.