For some reason Discounts are the only thing that use "store/" in a prefix, for example:
example.com/admin/commerce/store/discounts/...

Whereas everything else in Commerce is simply found at /admin/commerce/...

Obviously a nitpick but it's one of those things that seems like it should not be this way.

CommentFileSizeAuthor
#6 remove_store_from_the-2591767-6.patch11.08 KBjoelpittet
#6 interdiff.txt1.81 KBjoelpittet
#5 2591767-remove-store-uri.notests-do-not-test.patch578 bytestorgospizza
#2 2591767-remove-store-uri.patch9.97 KBtorgospizza

Comments

torgosPizza created an issue. See original summary.

torgospizza’s picture

torgospizza
he/him
Primary language English
Location Portland, OR
commented
Status: Active » Needs review
Issue tags: +Commerce Sprint
StatusFileSize
new 2591767-remove-store-uri.patch9.97 KB

Patch attached, tested and working for me, but automated tests will be nice to see what they come back with.

Status: Needs review » Needs work

The last submitted patch, 2: 2591767-remove-store-uri.patch, failed testing.

torgospizza’s picture

torgospizza
he/him
Primary language English
Location Portland, OR
commented

Not sure why the tests are failing, unless a cache-clear is required for testbot not to choke?

torgospizza’s picture

torgospizza
he/him
Primary language English
Location Portland, OR
commented
StatusFileSize
new 2591767-remove-store-uri.notests-do-not-test.patch578 bytes

I think I understand. We should probably do this in two stages, one with just the patch that doesn't get tested. if someone can roll that into -dev I could submit the test part of the patch in a followup comment.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt1.81 KB
new remove_store_from_the-2591767-6.patch11.08 KB

I think you just missed a couple spots.

torgospizza’s picture

torgospizza
he/him
Primary language English
Location Portland, OR
commented

Not sure how I missed those. Thanks Joel!

torgospizza’s picture

torgospizza
he/him
Primary language English
Location Portland, OR
commented
Status: Needs review » Reviewed & tested by the community

Haha, yeah not missing those spots makes the tests pass, who'da thunk it? :P

It's such a small change, setting to RTBC as I'm going to push this to Production so I can stop typing in "store" every time I want to head to the Discounts page.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Reviewed & tested by the community » Fixed

You type in the URLs! You may want to use something like coffee:P

Committed and pushed to -dev. thanks @torgosPizza

torgospizza’s picture

torgospizza
he/him
Primary language English
Location Portland, OR
commented

It really depends on how much of a hurry I'm in :) Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.