For some reason Discounts are the only thing that use "store/" in a prefix, for example:
example.com/admin/commerce/store/discounts/...
Whereas everything else in Commerce is simply found at /admin/commerce/...
Obviously a nitpick but it's one of those things that seems like it should not be this way.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | remove_store_from_the-2591767-6.patch | 11.08 KB | joelpittet |
| #6 | interdiff.txt | 1.81 KB | joelpittet |
| #5 | 2591767-remove-store-uri.notests-do-not-test.patch | 578 bytes | torgospizza |
Comments
Comment #2
torgospizzaPatch attached, tested and working for me, but automated tests will be nice to see what they come back with.
Comment #4
torgospizzaNot sure why the tests are failing, unless a cache-clear is required for testbot not to choke?
Comment #5
torgospizzaI think I understand. We should probably do this in two stages, one with just the patch that doesn't get tested. if someone can roll that into -dev I could submit the test part of the patch in a followup comment.
Comment #6
joelpittetI think you just missed a couple spots.
Comment #7
torgospizzaNot sure how I missed those. Thanks Joel!
Comment #8
torgospizzaHaha, yeah not missing those spots makes the tests pass, who'da thunk it? :P
It's such a small change, setting to RTBC as I'm going to push this to Production so I can stop typing in "store" every time I want to head to the Discounts page.
Comment #9
joelpittetYou type in the URLs! You may want to use something like coffee:P
Committed and pushed to -dev. thanks @torgosPizza
Comment #11
torgospizzaIt really depends on how much of a hurry I'm in :) Thanks!