There are lots of selectors that have LTR properties, duplicated in the *.rtl.css file. It's hard to keep track of them with that file disassociation.
Using the [dir="rtl"] and [dir='ltr'] attribute selectors we can adjust the RTL specific properties inline with the LTR selectors. So it's easier then to remember to change the corresponding selector.
This is how D8 does things and works with IE7+
Follow-up to #2558547: Improve the default sort of the primary discount View
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | Edit_PF___Drupal_standard_after.png | 61.68 KB | joelpittet |
| #13 | Edit_PF___Drupal_standard.png | 60.45 KB | joelpittet |
| #13 | Edit_PF___Drupal_standard_-_Before.png | 83.73 KB | joelpittet |
| #13 | Edit_PF___Drupal_standard.png | 71.43 KB | joelpittet |
| #11 | use_dir_rtl_for_rtl-2591433-11.patch | 28.68 KB | joelpittet |
Comments
Comment #2
joelpittetHere's a patch to do this.
This needs screenshots before and after for the RTL and LTR versions.
Comment #3
joelpittetComment #4
torgospizzaWorks well for me! In the first screenshot, it would become impossible to select the offer type in the middle. Hence the blue highlight that occurred when attempting to click.
Note: I was actually clicking the "% off" tab here but my cursor is invisible in the screenshot.
After the patch, I can select everything just fine.
Things look pretty much the same before and after the patch from a stylistic standpoint but the UX feels much improved.
Comment #5
joelpittetOh that is interesting, it should just be fixing RTL;) Thanks for testing that out @torgosPizza
Comment #6
torgospizzaHmm yeah that might have been thanks to #2574751: Unable to change offer type as well. (I came to this issue from that one.)
In any case it seems to work well. I don't use any RTL languages so someone else may have to test that particular aspect but, I'm sure it's fine.
Thanks!
Comment #7
joelpittetRe-rolled. The screenshots needed would be the RTL vs LTR. you can install another language or just cheat and set the
dir="rtl"on the html tag to get an approximation.Comment #8
torgospizzaAh. Sorry for the noise :)
Comment #11
joelpittetRe-rolled due to changes.
Comment #12
joelpittetOk this should be good.
Comment #13
joelpittetBefore RTL:
After RTL:
Before LTR:
After LTR:
Comment #15
joelpittetOk this has been committed to dev.