Redirect after password expiry fails for modal forms login

@pooja One minor change - First letter of comment needs to be uppercase. // prompted for their current password on password change page unnecessarily.

Is there a way to do this without adding module-specific integration code? Password Policy should not need to know about other modules like "Modal forms (with ctools)". This line is specific to that module:

if (variable_get('modal_forms_login')) {

Such code adds complexity and makes the module difficult to test.

How do you "Enable modal forms for login form."?

I installed the Modal Forms module on a fresh Drupal site, but I don't see how to do it.

Steps of how to configure Modal Forms to reproduce the problem on a fresh Drupal site would be helpful.

"1. Enable modal forms for login form." <-- How do you do this?

Thanks, I am able to reproduce the problem now. I hadn't realized you have to create a link to user/login.

Looks like the problem is Modal Forms relies on a call to modal_forms_login() when the user is returned to user/login after submitting the login form. That function calls Ctools functions that close the modal window and perform the redirection. However, Password Policy calls drupal_goto() before that callback is executed, which attempts the redirection without closing the modal window.

I am thinking it is a problem that should be fixed in Modal Forms. Modal Forms should not assume that another module will not redirect to a different page. That is, Modal Forms should not assume the user will be returned to user/login after submitting the login form.

Again, adding any code like if (<modal_forms enabled>) to Password Policy is very undesirable. Password Policy should not need to know about other contributed modules.

One possible solution is to use hook_drupal_goto_alter() to execute the Ctools calls as does modal_forms_login(). The following seems to work, but I do not know whether it is secure or fully correct. Please consider it a proof of concept.

/**
 * Implements hook_drupal_goto_alter().
 */
function modal_forms_drupal_goto_alter(&$path, $options, &$http_response_code) {
  if (arg(0) == 'modal_forms' && arg(2) == 'login') {
    ctools_include('modal');
    ctools_include('ajax');
    $output = array();
    $output[] = ctools_modal_command_dismiss(t('Login success'));
    $output[] = ctools_ajax_command_redirect($path);
    print ajax_render($output);
    drupal_exit();
  }
}

That could be put in a separate module to avoid hacking changes to Modal Forms or Password Policy.

Would this approach be a solution to the problem?

Please re-open if the solution suggested in #20 is problematic.

Just to confirm, the solution in #20 works for me as well.