Closed (fixed)
Project:
Monitoring
Version:
8.x-1.x-dev
Component:
Sensors
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
7 Oct 2015 at 14:15 UTC
Updated:
12 Nov 2015 at 02:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
giancarlosotelo commentedAdded the function, wondering if it is enough.
Comment #3
berdirAs a first step, yes.
Additionally, it would be good to add a dependency on the actual config in case it is a config entity. So if we check for a specific view, we should also directly depend on that config.
I thought about doing that in a follow-up, but that's actually quite easy to identify. Load the config, if it exists and has a dependency key on the first level, we can assume it is a config entity, then add that to the dependencies too.
We should also have some test coverage for this, we can probably just extend our existing tests.
Comment #4
giancarlosotelo commentedOk, I think comments above are addressed.
Comment #5
juanse254 commentedTested locally seems to work.
Comment #6
juanse254 commentedComment #7
miro_dietikerI think that should be some string that refers to the specific config object... Not just plain TRUE... We should specifically test this.
Comment #8
giancarlosotelo commentedChanged on test.
Comment #9
miro_dietikerMuch nice! Thx, committed.