Problem/Motivation

Many tests are failing, some because of #2575869: Remove all remaining usage of deprecated UrlGeneratorInterface::generateFromPath() and delete it UrlGeneratorInterface::generateFromPath() has been removed and others because of #2520526: Calculate configuration entity dependencies on install but I am not sure exactly what's the problem with this one.

Proposed resolution

- Change generateFromPath call with the correct one, look at https://www.drupal.org/node/2581455.
- Investigate about the other issue.

CommentFileSizeAuthor
#15 2581697-15.patch5.65 KBgiancarlosotelo
#15 interdiff-12-15.txt1.62 KBgiancarlosotelo
#12 2581697-12.patch5.58 KBgiancarlosotelo
#12 interdiff-11-12.txt375 bytesgiancarlosotelo
#11 2581697-11.patch5.62 KBgiancarlosotelo
#11 interdiff-7-11.txt1.19 KBgiancarlosotelo
#7 2581697-7.patch4.35 KBgiancarlosotelo
#7 interdiff-4-7.txt1.65 KBgiancarlosotelo
#4 2581697-4.patch4.1 KBgiancarlosotelo
#4 interdiff-2-4.txt1.3 KBgiancarlosotelo
#2 2581697-2.patch2.55 KBgiancarlosotelo

Comments

giancarlosotelo created an issue. See original summary.

giancarlosotelo’s picture

giancarlosotelo commented
Status: Active » Needs review
StatusFileSize
new 2581697-2.patch2.55 KB

Here is the patch.

I spent some time trying to figure out the problem related to #2520526: Calculate configuration entity dependencies on install and we just have to load the entity type that we are going to use (?) in tests because the module is working well.

So now tests are green again.

Status: Needs review » Needs work

The last submitted patch, 2: 2581697-2.patch, failed testing.

giancarlosotelo’s picture

giancarlosotelo commented
StatusFileSize
new interdiff-2-4.txt1.3 KB
new 2581697-4.patch4.1 KB

In the meanwhile this was committed #2507031: Optimize automatic cron subscriber by moving automatic cron to a module so providing another fix for the failing test.

giancarlosotelo’s picture

giancarlosotelo commented
Status: Needs work » Needs review
berdir’s picture

berdir
Primary language German
Location Switzerland
commented 
  1. index 2456d9d..987f23f 100644
--- a/config/install/monitoring.sensor_config.core_cron_safe_threshold.yml

--- a/config/install/monitoring.sensor_config.core_cron_safe_threshold.yml
+++ b/config/install/monitoring.sensor_config.core_cron_safe_threshold.yml

+++ b/config/install/monitoring.sensor_config.core_cron_safe_threshold.yml
@@ -6,6 +6,6 @@ value_type: 'bool'

@@ -6,6 +6,6 @@ value_type: 'bool'
 category: 'Cron'
 status: TRUE
 settings:
-  config: 'system.cron'
-  key: 'threshold.autorun'
+  config: 'automated_cron.settings'

    We should move this sensor to optional then and make it dependant on the new automated_cron module. 

  2. +++ b/modules/multigraph/src/Tests/MultigraphServicesTest.php
@@ -118,7 +118,7 @@ class MultigraphServicesTest extends RESTTestBase {
-    $url = $this->container->get('url_generator')->generateFromPath($action, array('absolute' => TRUE, 'query' => $query));
+    $url = Url::fromUri('base:/' . $action, array('absolute' => TRUE, 'query' => $query));

    I think base has no leading /

giancarlosotelo’s picture

giancarlosotelo commented
StatusFileSize
new interdiff-4-7.txt1.65 KB
new 2581697-7.patch4.35 KB

Done.

The last submitted patch, 2: 2581697-2.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 7: 2581697-7.patch, failed testing.

The last submitted patch, 7: 2581697-7.patch, failed testing.

giancarlosotelo’s picture

giancarlosotelo commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-7-11.txt1.19 KB
new 2581697-11.patch5.62 KB

Created a follow up #2581815: Add dependencies to the ConfigValue sensor. and fix for the UI Test now we have to enable the sensor.

giancarlosotelo’s picture

giancarlosotelo commented
StatusFileSize
new interdiff-11-12.txt375 bytes
new 2581697-12.patch5.58 KB

Missing an empty line.

The last submitted patch, 11: 2581697-11.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 12: 2581697-12.patch, failed testing.

giancarlosotelo’s picture

giancarlosotelo commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-12-15.txt1.62 KB
new 2581697-15.patch5.65 KB

Ok maybe its better to do so in the setup, some other tests are using the sensor.
This should be it

The last submitted patch, 11: 2581697-11.patch, failed testing.

The last submitted patch, 12: 2581697-12.patch, failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Looks good, but we don't need that line in setUp() at all, the sensor is enabled by default. Confirmed that it passes without and committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.