Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
simpletest.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
5 Oct 2015 at 14:18 UTC
Updated:
29 Oct 2015 at 18:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #4
benjy commentedLets try this.
Comment #5
benjy commentedTagging this rc eligible given it's test only changes.
Comment #6
jibranGiven that we are only making the existing functionality configurable by moving it to base class that's why I think it's a task. This is good addition and very helpful for contrib.
Patch looks good as is but we also use static:$module pattern in TestBase and then merge all the arrays in setUp method. Do you think we should also do that here as well so that no test can overwrite the existing array. Other then that I think this change needs change record.
Comment #7
benjy commentedOK, i've refactored to merge all test exceptions the same way modules works.
Do we normal write change records for changes only in tests?
Comment #8
jibranI think it is worth adding change record or at least update All TestBase derived tests now enforce strict configuration schema adherence by default. Patch looks good now.
Comment #9
benjy commentedOK, i'll update the existing change record with an example of this, but not until after it's committed.
Comment #10
sam152 commentedDifferent property names are used here.
Comment #11
sam152 commentedNevermind, configSchemaExceptions is used on the test base and exceptions on the event.
Setting back to RTBC.
Comment #12
alexpottI started to rename some things on commit and make everything more consistent. I got too large so uploading a new patch. I think that using the word
exceptionsis confusing when the ConfigSchemaChecker throws exceptions. I've changed it to be exclusions and I've made all the doc blocks consistent.I agree this change is rc eligible.
Comment #13
benjy commentedLooks good to me, thanks.
Comment #14
jibran+1 to RTBC.
Comment #15
effulgentsia commentedLooks good. Ticking credit box for @jibran for reviews.
Comment #16
effulgentsia commentedPushed to 8.0.x.