PHP notices while editing atom in CTools modal box

I think that, that function has to run, as it is the one that creates the new Atom entity and such.

And we cannot check whether form state values is empty or not (outside of the hook), because the idea behind the hook in that function was that the provider decides how many entity it needs.

So in fact the issue is in the image provider and any provider that implements this hook, to not do something that can throw a notice.

So attached a patch that fixes this for the base providers.

Although it seems i cant reproduce the problem here, as that code only runs if
if (empty($form_state['scald'])) {
And form_state scald is not empty for me if i edit an atom.

So for me this situation never appears.
Any additional steps to reproduce?

Because in the
function scald_atom_edit_page($js, $atom) {
It will use
ctools_object_cache_set('scald_atom', 'edit:' . $atom->sid, $scald);
Which is then read

  $form_state = array(
    'ajax' => $js,
    'scald' => ctools_object_cache_get('scald_atom', $cache_id),
  );

So in fact if you are editing atoms it cannot be empty.

Unless its possible to somehow avoid using that edit_page function and not have this cache.

I think that "scald_atom_add_page" should not be called when clicking the finish on the edit form, that might be the real bug.

But still checking.

I see, then the bug is that it does too much in that step, maybe a code restructure is needed.

When adding a new atom:
If the first step is options and not add, then form_state values will be empty.
Yet that function should run, because it will create the single atom entity or whatever the provider defines.

So then i think patch #2 breaks that.

Patch #3 would remove the notice, but it requires all providers to pay attention to it, and add issets.

Alternatively if we can detect that its just about to close and add that to the if, it could be a good solution as well.

Maybe this patch will work.

The idea behind it is that when rendering the options form, we can check whether
$form_state['scald']['atoms']
is empty or not. If its empty then very likely its not an edit form, and it had no first add step, as otherwise it would not be empty.
And then we can run that function.

Please test :)

In fact because of that we can spare one more line.

Great! Will commit tomorrow if no negative feedback til then :)

Thanks, Committed.