[Policy] Should tests fail based on strict standards warnings

Unless Im mistaken, this is not how the current PIFT/PIFR bots behave, and therefore not a blocker to shutting them off.

This is something drupalCI should do, and we'll add it, but not before we shut off the old bots.

We definitely need to fix the fatal error that is related to this issue, but Strict Standards warnings are not indicative of a failed test, nor did they fail before on the old testbots.

Yes, they failed on the old bots - hence the other core critical.

That is why this is critical and hence blocking turning off of the old bots.

I just went and looked deeper,

The old testbots did *not* run PHP Strict Standards at all, so this would not be a regression from current functionality.

Whether or not tests *should* fail on Strict Standards warnings is another matter entirely. It may be that we want to emit debug messages, or something else to indicate a warning, but not necessarily fail a whole test for it.

Sorry, I mixed things up with #2580293: Patch having test with "PHP Fatal error" is marked as PASSED, which is the critical part.

This issue will be for discussing failures of strict standards. Added a related issue to at least provide that information, regardless of whether or not it fails the tests.