This error was revealed in the old bot test https://qa.drupal.org/pifr/test/1170668.
PHP Strict Standards: Drupal\simpletest\WebTestBase and Drupal\simpletest\AssertContentTrait define the same property ($content) in the composition of Drupal\system\Tests\Render\AjaxPageStateTest. This might be incompatible, to improve maintainability consider using accessor methods in traits instead. Class was composed in /var/lib/drupaltestbot/sites/default/files/checkout/core/modules/system/src/Tests/Render/AjaxPageStateTest.php on line 115
Checking the cause I found that \Drupal\system\Tests\Render\AjaxPageStateTest uses the \Drupal\simpletest\AssertContentTrait trait. But AjaxPageStateTest extends WebTestBase and that is already using the same trait.
Remove the use AssertContentTrait; from \Drupal\system\Tests\Render\AjaxPageStateTest.
None.
None.
None.
None.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | ajax.png | 714.01 KB | claudiu.cristea |
| trait_included_twice.patch | 612 bytes | claudiu.cristea |
Comments
Comment #2
claudiu.cristeaComment #3
claudiu.cristeaIt's a followup of #2497115: ajax_page_state is not taken into account for normal GET requests.
Comment #4
claudiu.cristeaThis is visible also on drupalci now, but it doesn't make the test fail.
Comment #5
claudiu.cristeaI guess is critical?
Comment #7
effulgentsia commentedPushed to 8.0.x. Thanks!
Comment #8
fabianx commentedWe need a critical follow-up for Drupal CI please ...
Comment #9
claudiu.cristea@Fabianx, if I understood well this is what we need #2579985: [Policy] Should tests fail based on strict standards warnings?
Comment #11
claudiu.cristeaThe old bot arrived to late for the dinner. Fixed per #7.