db-tools.php import does not work

Blocks #2568203: Remove migrate-db.sh in favor of core tools.

Have a test, yo. Let's get this in by RC.

Looks good.

+++ b/core/lib/Drupal/Core/Command/DbImportCommand.php
@@ -58,6 +58,8 @@ protected function execute(InputInterface $input, OutputInterface $output) {
+    Database::setActiveConnection($connection->getKey());

If you overwrite the global connection, we should reset it at the end. It should be as simple as something like this:

$old_key = Database::setActiveConnection($connection->getKey());
//code
Database::setActiveConnection($old_key);

Done!

Looks good!

Should have caught this the first review... sorry.

+++ b/core/modules/system/tests/src/Kernel/Scripts/DbImportCommandTest.php
@@ -56,18 +55,21 @@ class DbImportCommandTest extends KernelTestBase {
-    /** @var \Drupal\Core\Database\Connection $connection */
-    $connection = $this->container->get('database');
-    // Drop tables to avoid conflicts.
-    foreach ($this->tables as $table) {
-      $connection->schema()->dropTable($table);
-    }
+    $connection_info = array(
+      'driver' => 'sqlite',
+      'database' => ':memory:',
+    );
+    Database::addConnectionInfo($this->databasePrefix, 'default', $connection_info);

Should add @requires extension pdo_sqlite to this test method.

Nice catch. All set!

Enabled and disabled pdo_sqlite locally and everything ran smoothly. Going to look into the previous failures but they're in "Drupal\toolbar\Tests\ToolbarAdminMenuTest" so its seems unrelated so RTBC'ing now.

I'm told their working on the toolbar hash failure over here. #2075889: Make Drupal handle incoming paths in a case-insensitive fashion for routing

Awesome-sauce!

Committed and pushed to 8.0.x. Thanks!

PIFT = Pain In my Frigging Tush.