Closed (fixed)
Project:
Metatag
Version:
8.x-1.x-dev
Component:
User interface
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
2 Oct 2015 at 18:30 UTC
Updated:
25 Oct 2015 at 23:04 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
damienmckennaThere's code in it that used to work, but it must have stopped working recently.
Comment #3
larowlanThere are tests in comment module for this, will adapt
Comment #4
michelleThis is the code in question. It did work last Spring. :) But that was a number of D8 Betas ago.
Comment #5
michelleLooks like a few things have changed. Here's a patch that works with Beta 16. (Sorry, haven't gone to RC 1 just yet. :) )
Comment #6
damienmckennaCommitted. Thanks Michelle!
Comment #8
larowlanwithout a test :( - should I add a new issue for a follow up? Or add test here?
Comment #9
damienmckennaPlease add new issue for tests for existing changes, or just roll it into the main "add tests" issue.
Comment #10
michelle@larowlan - Sorry. :( Learning to write tests is on my "to learn" list but I haven't gotten to it, yet.
Comment #11
larowlanAdded test coverage in #2563637: Write tests for the 8.x-1.x functionality for this bug.