Problem/Motivation

See core change record: !placeholder removed from t() and format_string()

Proposed resolution

Replace with @placeholder except URLs which get :placeholder (see New :variable placeholder for URLs in HTML attributes added to SafeMarkup::format() and t()).

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 features-placeholder-2579231-2.patch18.48 KBnedjo
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nedjo created an issue. See original summary.

nedjo’s picture

nedjo
he/him/his
Primary language English
CreditAttribution: nedjo at Chocolate Lily commented
FileSize
features-placeholder-2579231-2.patch18.48 KB

Patch attached. Not sure we strictly need to change the placeholders in drush dt() calls, but for consistency I've done so.

Without this change, there is an initially puzzling bug: clicking one of the generation buttons on the features generation form leads to the feature create/edit form.

nedjo’s picture

nedjo
he/him/his
Primary language English
CreditAttribution: nedjo at Chocolate Lily commented
Status: Active » Needs review
nedjo’s picture

nedjo
he/him/his
Primary language English
CreditAttribution: nedjo at Chocolate Lily commented
Priority: Normal » Critical

Critical because breaks Features with latest Drupal core release.

nedjo’s picture

nedjo
he/him/his
Primary language English
CreditAttribution: nedjo at Chocolate Lily commented
Assigned: Unassigned » nedjo
mpotter’s picture

mpotter CreditAttribution: mpotter commented

I think looks mostly good. One test is to put basic HTML in a Feature description, like EM or STRONG tags and make sure they work correctly in the UI. That's the only place where Features allows any markup.

  • nedjo committed 719e024 on 8.x-3.x 
    Issue #2579231 by nedjo: Replace usage of !placeholder in t() and...
nedjo’s picture

nedjo
he/him/his
Primary language English
CreditAttribution: nedjo at Chocolate Lily commented
Status: Needs review » Fixed

@mpotter: thx, I did some quick testing and the description HTML seems to come through fine.

Status: Fixed » Needs work

The last submitted patch, 2: features-placeholder-2579231-2.patch, failed testing.

nedjo’s picture

nedjo
he/him/his
Primary language English
CreditAttribution: nedjo at Chocolate Lily commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.