http://www.eitb.eus/es/ considered not valid URL on field validation.

CommentFileSizeAuthor
#7 interdiff.txt602 bytesrenatog
#7 validation_error-2578521-7.patch.patch669 bytesrenatog
#2 validation_error-2578521-2.patch660 byteskala4ek

Comments

arialvix created an issue. See original summary.

kala4ek’s picture

kala4ek
Primary language Russian
Location 🇷🇺 Novosibirsk
commented
Version: 7.x-1.3 » 7.x-1.x-dev
Status: Active » Needs review
StatusFileSize
new validation_error-2578521-2.patch660 bytes

This simple patch should help you.

soapboxcicero’s picture

soapboxcicero commented

I've just received a similar report for a .realtor domain. There are a lot of top level domains. Maybe listing them in a regex is counterproductive and it should just validate that there's something vaguely TLD-like there?

kala4ek’s picture

kala4ek
Primary language Russian
Location 🇷🇺 Novosibirsk
commented
Priority: Minor » Normal
Status: Needs review » Needs work

@soapboxcicero, I think you are right.
Also, set up priority to "Normal", because I thinks that module which works with links does not have bugs like this.

ervit’s picture

ervit commented

And this link is not accepted either: https://www.tlv.partners/a-simple-tool-to-help-you-with-cap-tables-and-e...

renatog’s picture

renatog commented
Status: Needs work » Reviewed & tested by the community
Issue tags: +#ciandt-contrib, +ciandt-contrib

Thanks you very much @kala4ek.

Works Good.

renatog’s picture

renatog commented
StatusFileSize
new validation_error-2578521-7.patch.patch669 bytes
new interdiff.txt602 bytes

New patch for fix #5 for @ervit.

  • RenatoG committed 3a22e7f on 7.x-1.x 
    Issue #2578521 by kala4ek, arialvix, soapboxcicero, ervit, RenatoG:...
renatog’s picture

renatog commented
Assigned: Unassigned » renatog
Status: Reviewed & tested by the community » Fixed

Fixed.

Commited in dev branch.

Regards.

r0nn1ef’s picture

r0nn1ef commented

I ran into this with the ".community" TLD, but actually, what would help is if there were actually an admin form to enter more allowed domains. The module already has a variable named 'link_extra_domains' that is loaded when validating (@see _link_domains()). I'm going to see if i can get this worked up and submit the patch.

r0nn1ef’s picture

r0nn1ef commented
Status: Fixed » Needs work
renatog’s picture

renatog commented

Coincidentally I was thinking about it @r0nn1ef.

Let's work on this soon and I'll let you know.

Thank you very much @r0nn1ef.

Regards.

renatog’s picture

renatog commented
Status: Needs work » Fixed

Hi people.

Fixed in this issue:

#2299657: Allow any TLD because site admins can never keep up with ICANN

Thank you very much.

Regards.

r0nn1ef’s picture

r0nn1ef commented

You beat me to it RenatoG ... I was just about to check out the repo and add it. Kudos and thank you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.