We're looking at extending the functionality of nodehierarchy for a large project, but we'd like to be able to submit patches to the module without large amounts of reformatting or learning the coding conventions of the nodehierarchy module. I'd like to suggest that this module be made to follow the Drupal Coding Standards, which are based on the PEAR standards.

I know these patches are large, but consistency in coding standards would really, really be appreciated as we look to be submitting patches on a regular basis. They make absolutely no changes to existing code or comments, other than reformatting to follow the standards. Some changes:

- Tabs replaced with spaces.
- Extra whitespace removed from end of lines.
- Comments begin with capital letters and end with periods.
- PHPdoc used for functions, properly formatted.
- Constants TRUE and FALSE are set to capitals.
- Extra spacing removed from function calls, this was very, very common (i.e. my_function( $param, $param2 ));
- Various formatting problems reported by coder.module

CommentFileSizeAuthor
nodehierarchy_cleanup6.patch89.5 KBquicksketch
nodehierarchy_cleanup5.patch79.45 KBquicksketch

Comments

ronan’s picture

ronan commented

Wow, that's a lot of work. Thanks a million for that. I'll apply and review these patches and get them committed as soon as I can.

Ronan

ronan’s picture

ronan commented
Status: Needs review » Fixed

I've reviewed, tested and committed both patches to 5.x-1.x-dev and 6.x-1.x-dev, thanks again for all this hard work

Ronan

quicksketch’s picture

quicksketch
he/him
commented

Thanks Ronan!

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.