Problem/Motivation

Drupal 8 will have PHP7 support as soon as that's possible, but at the moment we have segfaults in the test suite due to PHP 7 bugs. Also because of that, if we introduce PHP7 incompatibilities we don't get properly warned about them.

Proposed resolution

Add a hook_requirements() warning, not error, indicating that PHP 7 is not yet fully supported and should only be run for testing purposes. We can then remove that as soon as we get to a 100% pass rate or there is a stable PHP 7 release.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#6 php7Requirements.png79.79 KBserg2
#4 2576745-4.patch717 bytesstefan.r

Comments

catch created an issue. See original summary.

catch’s picture

catch
he/him
Primary language English
commented
Issue tags: +rc target

Tagging RC target since this will prevent some duplicate bug reports/confusion when people try things out.

dawehner’s picture

dawehner
Primary language German
commented

On top of that we should be able to adapt our composer.json file to just have support < 7.0

stefan.r’s picture

stefan.r commented
Status: Active » Needs review
Issue tags: +Needs manual testing
StatusFileSize
new 2576745-4.patch717 bytes
dawehner’s picture

dawehner
Primary language German
commented

We could also just use https://www.drupal.org/node/2575469 + the composer.json entry for the validation.

serg2’s picture

serg2 commented
StatusFileSize
new php7Requirements.png79.79 KB

Seem to be working as intended.
When running PHP7 the message appears as a requirements warning on installation and on status page.
When running PHP5 the message does not appear at all.

php 7 Requirements

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

I think this is plenty for now.

#2575469: Require the composer/semver library to do version checking. is good follow-up material.

moshe weitzman’s picture

moshe weitzman commented

This is overly aggressive IMO. It can be a release note item. We want to encourage early adoption of PHP7 not discourage it. These folks ferret out bugs and enjoy better performance.

This is OK for now. We hope not to ship 8.0.0 with this warning.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Postponed

I think we should only add this if PHP7 tests are failing when we release Drupal 8 - on the latest version of PHP7 available at that time.

jcnventura’s picture

jcnventura
Primary language English
commented
Related issues: +#2454439: [META] Support PHP 7
jcnventura’s picture

jcnventura
Primary language English
commented
Issue tags: -Novice, -rc target +revisit before stable release
catch’s picture

catch
he/him
Primary language English
commented
Status: Postponed » Closed (duplicate)

Now that we're green on #2454439: [META] Support PHP 7 and have two specific upstream PHP reports - one of which has a commit and one of which is getting active attention, I'm going to go ahead and mark this duplicate. In terms of Drupal 8, we have PHP 7 compatibility that shouldn't regress, what's remaining is just PHP 7 bugs that happened to affect our test suite.