See the change record: !placeholder removed from t() and format_string().
So, I'd guess if we ran the tests now they would fail, so we should preemptively fix this right away.

CommentFileSizeAuthor
#2 2576503-2--unescaped_placeholders--test.patch734 bytesdrunken monkey
#2 2576503-2--unescaped_placeholders.patch15.86 KBdrunken monkey

Comments

drunken monkey created an issue. See original summary.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Active » Needs review
StatusFileSize
new 2576503-2--unescaped_placeholders.patch15.86 KB
new 2576503-2--unescaped_placeholders--test.patch734 bytes

A patch that should fix this, and a dummy patch to check if this is really broken at the moment in our tests (though I guess it doesn't really matter).

Status: Needs review » Needs work

The last submitted patch, 2: 2576503-2--unescaped_placeholders--test.patch, failed testing.

The last submitted patch, 2: 2576503-2--unescaped_placeholders--test.patch, failed testing.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs work » Fixed

Excellent, good to see.
Committed.

  • drunken monkey committed d5714f4 on 8.x-1.x 
    Issue #2576503 by drunken monkey: Remove !placeholders from the module

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.