ctools_var_export() quotes numeric values as strings [#2576251]

Comment	File	Size	Author
#5	ctools-2576251-5.patch	858 bytes	Snehal Brahmbhatt
#2	2576251.ctools.var-export-quoted-string.patch	859 bytes	joachim

Comment #1

28 September 2015 at 13:31

joachim created an issue. See original summary.

Log in or register to post comments

Comment #2

joachim CreditAttribution: joachim commented 28 September 2015 at 13:33

Status:

Active

» Needs review

File	Size
2576251.ctools.var-export-quoted-string.patch	859 bytes

This is code taken from Features' version of the same function, features_var_export().

Probably needs testing with a variety of different imports, to make sure we're not introducing this bug: #1721926: Field Instance Export "weight" - brings me in a Override ping/pong - quotes and no quotes.

Log in or register to post comments

Comment #3

kenorb CreditAttribution: kenorb commented 21 April 2016 at 13:52

Log in or register to post comments

Comment #4

Chris Matthews CreditAttribution: Chris Matthews as a volunteer commented 22 January 2019 at 02:06

Status:	Needs review	» Needs work
Issue tags:		+Needs reroll

The 3 year old patch to export.inc does not apply to the latest ctools 7.x-1.x-dev.

Checking patch includes/export.inc...
error: while searching for:
    // export and casting it back to an object when evaluated.
    $output = '(object) ' . ctools_var_export((array) $var, $prefix);
  }
  else if (is_bool($var)) {
    $output = $var ? 'TRUE' : 'FALSE';
  }

error: patch failed: includes/export.inc:880
error: includes/export.inc: patch does not apply