I change the interval setting from the default of 8000 to 1000 (and even less), but it is completely ignored. It's as if the interval has been hard coded to 8000. I need to control this myself.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jmev created an issue. See original summary.

piyuesh23’s picture

Status: Active » Needs review
FileSize
2.5 KB

The interval configuration has been moved to another keyword called pause in the library. Updated the module to handle that.

Uploading patch for the fix.

piyuesh23’s picture

Issue tags: +SprintWeekend2016
piyuesh23’s picture

naveenvalecha’s picture

Version: 7.x-1.0 » 7.x-1.x-dev

correcting version

naveenvalecha’s picture

Well patch looks good to me. We need hook_update for updating the config of existing jquery_carousel config ?
Reg. css change,@saki007ster would be happy with that.

piyuesh23’s picture

@naveenvalecha,

Thanks for the quick review. Don't think we need an update hook here right away. There could be multiple fields with the configuration for the same. In any case, the default value for pause setting is picked up by the jQuery plugin whenever its not available.

  • piyuesh23 committed c1dcc57 on
    Issue #2575965 by piyuesh23: Interval setting ignored
    
piyuesh23’s picture

Status: Needs review » Closed (fixed)
naveenvalecha’s picture

Status: Closed (fixed) » Fixed
naveenvalecha’s picture

Re #7 : Agreed, the default value is controlled by the module and we are not allowing anywhere user to update the default value. but it is needed for the interval -> pause key that we are updating, its needed b/c the old key will left in system.If we are not doing then we are leaving our mess in existing config.

In any case, the default value for pause setting is picked up by the jQuery plugin whenever its not available.

+1 yep let's use this as a fallback

  • piyuesh23 committed c1dcc57 on
    Issue #2575965 by piyuesh23: Interval setting ignored
    

  • naveenvalecha committed 7ee3064 on 8.x-1.x
    Merge branch '8.x-1.x' of git.drupal.org:project/jquery_carousel into 8....

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.