Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I change the interval setting from the default of 8000 to 1000 (and even less), but it is completely ignored. It's as if the interval has been hard coded to 8000. I need to control this myself.
Comment | File | Size | Author |
---|---|---|---|
#2 | jquery_carousel-renaming_interval_to_pause-2575965-2-7.x-1.x.patch | 2.5 KB | piyuesh23 |
Comments
Comment #2
piyuesh23 CreditAttribution: piyuesh23 at QED42 commentedThe interval configuration has been moved to another keyword called pause in the library. Updated the module to handle that.
Uploading patch for the fix.
Comment #3
piyuesh23 CreditAttribution: piyuesh23 at QED42 commentedComment #4
piyuesh23 CreditAttribution: piyuesh23 at QED42 commentedComment #5
naveenvalechacorrecting version
Comment #6
naveenvalechaWell patch looks good to me. We need hook_update for updating the config of existing jquery_carousel config ?
Reg. css change,@saki007ster would be happy with that.
Comment #7
piyuesh23 CreditAttribution: piyuesh23 at QED42 commented@naveenvalecha,
Thanks for the quick review. Don't think we need an update hook here right away. There could be multiple fields with the configuration for the same. In any case, the default value for pause setting is picked up by the jQuery plugin whenever its not available.
Comment #9
piyuesh23 CreditAttribution: piyuesh23 at QED42 commentedComment #10
naveenvalechaComment #11
naveenvalechaRe #7 : Agreed, the default value is controlled by the module and we are not allowing anywhere user to update the default value. but it is needed for the interval -> pause key that we are updating, its needed b/c the old key will left in system.If we are not doing then we are leaving our mess in existing config.
+1 yep let's use this as a fallback