Settings on DsField implementations doesn't get picked up.

I have debugged it, and found that ds_preprocess_Field doesnt get called for the DsField implementations.

I also found out that the template_preprocess and the preprocess_field doesn't get called for the other fields.

Maybe core has changed and broken this.

I will try to find out why, xdebug ftw!

/**
 * Custom output all HTML for the field.
 */
function theme_ds_field_expert($variables) {
  template_preprocess_field($variables, 'field');
  ds_preprocess_field($variables);

Comments

danielbeeke created an issue. See original summary.

danielbeeke’s picture

aspilicious’s picture

Oh no, not again :(
Third time in 4 years....

I'll try to figure out how we ca fix this.
Can you revert core to the commit before this one to verify that one works?
Would safe me a lot of time tomorrow.

danielbeeke’s picture

I have a d8 site with ds running beta15 - all working fine
I have a d8 site with ds running dev from around 21 sept and a couple of patches,

Best would I think to check it on HEAD,
I will see if I can do such a test tomorrow.

aspilicious’s picture

Status: Needs work » Needs review
StatusFileSize
new2.17 KB

Can you review this patch?

Anonymous’s picture

I succesfully tested your patch on Beta15, with ds 8.x-2.0-alpha10+31-dev and layout_plugin 8.x-1.0-alpha14+2-dev. Seems to be working for now.

  • aspilicious committed 2293236 on 8.x-2.x
    Issue #2575865 by aspilicious: ds_preprocess_field doesn't get picked up
    
aspilicious’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.