The live preview and seldom used pane styles tests both have these steps:
When I click "Close Window"
This step is supposed to close the CTools modal without making any changes. "Close Window" is the (hidden) text of the X in the upper right corner in the default Responsive Bartik theme. In the Radix theme, there's no "Close Window" text there. Instead, the special text character "×" is displayed. (This is in itself an accessibility issue for speech input users - it's not a real X, so it's not clear what they'd have to say to click that link.)
When running the tests on a Radix child theme, the live preview test failed because it couldn't find the Close Window link. This caused every subsequent javascript test in the run to fail. When the test suite needed to open a new page, the browser showed that modal that asks if you're sure you want to leave the page. All I got from there on out on javascript tests was this error:
Unexpected modal dialog (text: This page is asking you to confirm that you want to leave - data you have entered may not be saved.): This page is asking you to confirm that you want to leave - data you have entered may not be saved.
Possible solution:
Use the ESC key to close the dialog instead of clicking the link.
Comment | File | Size | Author |
---|---|---|---|
#12 | panopoly_test-radix-2574369-12.patch | 5.02 KB | cboyden |
Comments
Comment #2
dsnopekHm. I think this is a Radix bug.
The "Close Window" link comes from the CTools modal, which we should reasonably be able to depend on. Radix is doing some magic to replace the CTools modal with the Bootstrap one, and provides markup that doesn't include the "Close Window" text in the button. It should be Radix's responsibility (ideally) to keep it the same.
Let's address this there - I've made an issue #2576897: Replacement for CTools modal changes "Close Window" button text to "x"
Comment #3
dsnopekHm. My Radix patch would work except that Behat has different steps for links and buttons. :-/ We'd have to switch from
I click "Close Window"
toI press "Close Window"
. So, we'll need some changes in Panopoly anyway...Comment #4
dsnopekHere's a patch that makes the Panopoly changes - it'll work in combination with the Radix patch.
Comment #5
dsnopekI've started testing Radix with the Panopoly tests more generally, and I'm expanding the scope of this issue to be any changes necessary to make that work.
This addresses issues with the panopoly_magic/display_type.feature test that failed because Radix structured the markup for radio buttons differently.
Comment #6
dsnopekThis fixes the panopoly_magic/add_content_preview.feature tests.
Comment #7
dsnopekMissed a couple instances of 'Close Window'
Comment #8
cboyden CreditAttribution: cboyden commentedI've been using the patch in #7 for a while and it's working as expected.
Comment #9
cboyden CreditAttribution: cboyden commentedChanges due to #2773683: Can't distinguish Add links on Add Content dialog being committed are going to require a reroll of this.
Comment #10
cboyden CreditAttribution: cboyden commentedPatch is rerolled to apply to latest dev.
Comment #11
cboyden CreditAttribution: cboyden commentedPrevious patch didn't include a change to a "should not see" step.
Comment #12
cboyden CreditAttribution: cboyden commentedPatch is updated to account for directory structure changes in the 1.42 release.
Comment #13
dsnopekRunning on Travis really quick:
https://travis-ci.org/panopoly/panopoly/builds/622810079EDIT: That build failed for a stupid reason - I made some changes to my Travis script, and here's a new build:
https://travis-ci.org/panopoly/panopoly/builds/622836058
Comment #15
dsnopekTests passing so committed!