The live preview and seldom used pane styles tests both have these steps:

When I click "Close Window"

This step is supposed to close the CTools modal without making any changes. "Close Window" is the (hidden) text of the X in the upper right corner in the default Responsive Bartik theme. In the Radix theme, there's no "Close Window" text there. Instead, the special text character "×" is displayed. (This is in itself an accessibility issue for speech input users - it's not a real X, so it's not clear what they'd have to say to click that link.)

When running the tests on a Radix child theme, the live preview test failed because it couldn't find the Close Window link. This caused every subsequent javascript test in the run to fail. When the test suite needed to open a new page, the browser showed that modal that asks if you're sure you want to leave the page. All I got from there on out on javascript tests was this error:

Unexpected modal dialog (text: This page is asking you to confirm that you want to leave - data you have entered may not be saved.): This page is asking you to confirm that you want to leave - data you have entered may not be saved.

Possible solution:
Use the ESC key to close the dialog instead of clicking the link.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

cboyden created an issue. See original summary.

dsnopek’s picture

Hm. I think this is a Radix bug.

The "Close Window" link comes from the CTools modal, which we should reasonably be able to depend on. Radix is doing some magic to replace the CTools modal with the Bootstrap one, and provides markup that doesn't include the "Close Window" text in the button. It should be Radix's responsibility (ideally) to keep it the same.

Let's address this there - I've made an issue #2576897: Replacement for CTools modal changes "Close Window" button text to "x"

dsnopek’s picture

Hm. My Radix patch would work except that Behat has different steps for links and buttons. :-/ We'd have to switch from I click "Close Window" to I press "Close Window". So, we'll need some changes in Panopoly anyway...

dsnopek’s picture

Title: Tests depend on theme text; cause all subsequent tests to fail » Tests fail with Radix because of CTools dialog changes
Status: Active » Needs review
FileSize
1.75 KB

Here's a patch that makes the Panopoly changes - it'll work in combination with the Radix patch.

dsnopek’s picture

Title: Tests fail with Radix because of CTools dialog changes » Tests fail with Radix
FileSize
2.4 KB

I've started testing Radix with the Panopoly tests more generally, and I'm expanding the scope of this issue to be any changes necessary to make that work.

This addresses issues with the panopoly_magic/display_type.feature test that failed because Radix structured the markup for radio buttons differently.

dsnopek’s picture

FileSize
3.93 KB

This fixes the panopoly_magic/add_content_preview.feature tests.

dsnopek’s picture

FileSize
5.01 KB

Missed a couple instances of 'Close Window'

cboyden’s picture

Status: Needs review » Reviewed & tested by the community

I've been using the patch in #7 for a while and it's working as expected.

cboyden’s picture

Assigned: Unassigned » cboyden
Status: Reviewed & tested by the community » Needs work

Changes due to #2773683: Can't distinguish Add links on Add Content dialog being committed are going to require a reroll of this.

cboyden’s picture

Assigned: cboyden » Unassigned
Status: Needs work » Needs review
FileSize
4.43 KB
983 bytes

Patch is rerolled to apply to latest dev.

cboyden’s picture

FileSize
5.02 KB
1.55 KB

Previous patch didn't include a change to a "should not see" step.

cboyden’s picture

FileSize
5.02 KB

Patch is updated to account for directory structure changes in the 1.42 release.

dsnopek’s picture

Running on Travis really quick:

https://travis-ci.org/panopoly/panopoly/builds/622810079

EDIT: That build failed for a stupid reason - I made some changes to my Travis script, and here's a new build:

https://travis-ci.org/panopoly/panopoly/builds/622836058

  • dsnopek committed 1a4110e on 7.x-1.x authored by cboyden
    Issue #2574369 by dsnopek, cboyden: Tests fail with Radix
    
dsnopek’s picture

Status: Needs review » Fixed

Tests passing so committed!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.