Replacement for CTools modal changes "Close Window" button text to "x"

You're adding ARIA landmarks, which means you're making an attempt at assistive technology support. I think to improve that support, you might also wrap the × in a <span aria-hidden="true">.

This is a similar pattern being used in Drupal 8 core on the new accesible pagers, where the number "1" is hidden from screen readers with an <span aria-hidden="true"> and then an additional <span class="visually-hidden">Go to Page 1</span> is what is read. Sighted users only see "1".

@jwilson3 Thanks for the reference to the new Drupal 8 approach. The pattern could be different here, since we're talking about form elements instead of pagers, which are implemented as links.

The expected behavior of the aria-label property is that it overrides the text/visible label of the form element it's applied to. Screenreader support for aria-label is good, so aria-hidden and element-invisible should not be needed. Speech input lags behind on ARIA support, but to the best of my knowledge the latest releases of major speech input products do support aria-label for buttons.

Of course for the automated test suite to work, there has to be some text for it to find, and aria-label won't work for that case.

We just tested this patch with Jaws, NVDA, and Dragon. It's working as expected with all three.